Received: from smtp4.mail.yahoo.com (smtp4.mail.yahoo.com [128.11.69.101]) by mail.postgresql.org (8.11.1/8.11.1) with SMTP id f18DJcx06788 for ; Thu, 8 Feb 2001 08:19:38 -0500 (EST) (envelope-from janwieck@yahoo.com) Received: from a5c54.pppool.de (HELO jupiter.greatbridge.com) (213.6.92.84) by smtp.mail.vip.suc.yahoo.com with SMTP; 8 Feb 2001 13:19:34 -0000 X-Apparently-From: Received: (from janwieck@localhost) by jupiter.greatbridge.com (8.9.3/8.9.3) id HAA03586; Thu, 8 Feb 2001 07:50:01 -0500 From: Jan Wieck Message-Id: <200102081250.HAA03586@jupiter.greatbridge.com> Subject: Re: Re: Postgres and Oracle differences and questions In-Reply-To: <28278.981560178@sss.pgh.pa.us> from Tom Lane at "Feb 7, 2001 10:36:18 am" To: Tom Lane Date: Thu, 8 Feb 2001 07:50:01 -0500 (EST) CC: Hannu Krosing , Jan Wieck , "D. Johnson" , pgsql-interfaces@postgreSQL.org X-Mailer: ELM [version 2.4ME+ PL68 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archive-Number: 200102/57 X-Sequence-Number: 1010 Tom Lane wrote: > > Speaking of which, though, it looks like an update or insert will > forcibly uncompress (and later recompress) a compressed-in-line datum, > which seems like a waste of cycles to me. Jan, shouldn't the test for > VARATT_IS_EXTENDED at line 357 instead read VARATT_IS_EXTERNAL? Not without some more logic added. We don't have any admin commands yet that can modify the toasters strategy on the attribute level, but the config attributes in the tuple descriptor are already there. So you can tell the toaster per attribute if it should try to compress or not, if it should try to keep the attribute in the main tuple harder and the like. You have to modify pg_attribute yourself for now, where we might want to have some ALTER TABLE, don't we? IIRC the above should only be invoked if you do something like INSERT ... SELECT, where the already toasted value is coming from another tuple than the one you're actually creating/updating. Jan -- #======================================================================# # It's easier to get forgiveness for being wrong than for being right. # # Let's break this rule - forgive me. # #================================================== JanWieck@Yahoo.com # _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com