Received: from candle.pha.pa.us (candle.navpoint.com [162.33.245.46]) by mail.postgresql.org (8.11.1/8.11.1) with ESMTP id f1LIrfx14606 for ; Wed, 21 Feb 2001 13:53:41 -0500 (EST) (envelope-from pgman@candle.pha.pa.us) Received: (from pgman@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id NAA28140; Wed, 21 Feb 2001 13:53:30 -0500 (EST) From: Bruce Momjian Message-Id: <200102211853.NAA28140@candle.pha.pa.us> Subject: Re: Patches for libpq++ In-Reply-To: <20010221185501.D16178@cistron.nl> "from J. T. Vermeulen at Feb 21, 2001 06:55:01 pm" To: "J. T. Vermeulen" Date: Wed, 21 Feb 2001 13:53:30 -0500 (EST) CC: pgsql-interfaces@postgresql.org X-Mailer: ELM [version 2.4ME+ PL77 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Archive-Number: 200102/142 X-Sequence-Number: 1099 > I'd like to suggest the following changes to bring libpq++ a bit more up to > date: > > - fixes include path in Makefile > - makes some member functions const > - flags (but does not fix) what looks like a memory leak and a warning > - changes int return type on ConnectionBad() to bool > > > diff -u -r postgresql-7.0.3/src/interfaces/libpq++/examples/Makefile postgresql-7.0.3-jtv/src/interfaces/libpq++/examples/Makefile > --- postgresql-7.0.3/src/interfaces/libpq++/examples/Makefile Thu Mar 2 03:00:59 2000 > +++ postgresql-7.0.3-jtv/src/interfaces/libpq++/examples/Makefile Wed Feb 21 16:16:14 2001 > @@ -4,7 +4,8 @@ > > > LIBNAME= libpq++ > -HEADERDIR= /usr/local/pgsql/include > +#HEADERDIR= /usr/local/pgsql/include > +HEADERDIR=/usr/include/postgresql > LIBPQDIR= /usr/local/pgsql/lib This change will not be made. The source install is /usr/local/pgsql/include. RPM's may install in /usr/include/postgresql, but we don't make such changes on our end of that. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026