Received: from candle.pha.pa.us ([162.33.245.46]) by mail.postgresql.org (8.11.1/8.11.1) with ESMTP id f1SHoRx61225 for ; Wed, 28 Feb 2001 12:50:27 -0500 (EST) (envelope-from pgman@candle.pha.pa.us) Received: (from pgman@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id MAA04577; Wed, 28 Feb 2001 12:42:05 -0500 (EST) From: Bruce Momjian Message-Id: <200102281742.MAA04577@candle.pha.pa.us> Subject: Re: Double newline bug with DBD::Pg: Where best to fix? In-Reply-To: "from Peter Eisentraut at Feb 28, 2001 06:11:06 pm" To: Peter Eisentraut Date: Wed, 28 Feb 2001 12:42:05 -0500 (EST) CC: Tom Lane , Dan Lyke , pgsql-interfaces@postgresql.org X-Mailer: ELM [version 2.4ME+ PL77 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Archive-Number: 200102/192 X-Sequence-Number: 1156 > Both of these whitespace-away-optimizing checks could probably be removed > completely, but I'm not sure whether there isn't some case that relies on > it. I'm gonna stare at it for a few hours and then check it in. Not sure why the optimizations are there either, though I thought I put them in there myself. However, now that I look at the diff, the tests were there in your initial 1.1 version too, I just moved them. I see no problem removing the tests, though at this late date, maybe the removal should happen in 7.2. Not sure. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026