Received: from candle.pha.pa.us ([162.33.245.46]) by mail.postgresql.org (8.11.1/8.11.1) with ESMTP id f1SIFHx64470 for ; Wed, 28 Feb 2001 13:15:17 -0500 (EST) (envelope-from pgman@candle.pha.pa.us) Received: (from pgman@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id NAA05912; Wed, 28 Feb 2001 13:06:55 -0500 (EST) From: Bruce Momjian Message-Id: <200102281806.NAA05912@candle.pha.pa.us> Subject: Re: Double newline bug with DBD::Pg: Where best to fix? In-Reply-To: <200102281732.MAA03971@candle.pha.pa.us> "from Bruce Momjian at Feb 28, 2001 12:32:25 pm" To: Bruce Momjian Date: Wed, 28 Feb 2001 13:06:55 -0500 (EST) CC: Peter Eisentraut , Tom Lane , Dan Lyke , pgsql-interfaces@postgresql.org X-Mailer: ELM [version 2.4ME+ PL77 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Archive-Number: 200102/193 X-Sequence-Number: 1157 > > Tom Lane writes: > > > > > That's all fine IMHO. But this isn't: > > > > > > regression=# select 'a string > > > regression'# > > > regression'# with a newline'; > > > ?column? > > > ------------------------- > > > a string > > > with a newline > > > (1 row) > > > > Well, *somebody* once figured that he could optimize away whitespace... > > Not so. Here's a patch that gets this case right: > Peter, I have thought about this some more. Seems we either add the 'quote' check, or remove the optimizations completely. Because we have to change it one way or the other for 7.1, it seems we should just remove the tests totally. Neither of us understand why they are even in the code. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026