From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200105090153.f491rWd17938@candle.pha.pa.us>
Subject: Re: Re: [INTERFACES] Postgres odbc driver bug
In-Reply-To: <3AF89956.47FEDBF5@tpf.co.jp> "from Hiroshi Inoue at May 9, 2001
	10:11:50 am"
To: Hiroshi Inoue <Inoue@tpf.co.jp>
Date: Tue, 8 May 2001 21:53:31 -0400 (EDT)
CC: Keith Millard <Kmillard@pumatech.com>,
	PostgreSQL odbc list <pgsql-odbc@postgresql.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII

> Bruce Momjian wrote:
> > 
> > OK, I have created a context diff of your changes, which is
> attached.
> > Can someone comment on this?  The patch appears to deal with
> > STMT_PREMATURE differently than our current code.
> > 
> > In fact, it seems to disable this code:
> > 
> >     /*
> >      * If the statement is premature, it means we already executed it from
> >      * an SQLPrepare/SQLDescribeCol type of scenario.  So just return
> >      * success.
> >      */
> >     if (stmt->prepare && stmt->status == STMT_PREMATURE)
> > 
> 
> Though this fixes the bug reported by Keith, STMT_PREMATURE
> loses its meaning and SC_pre_execute() does a non-essential
> work as a result. Possibly SQLPrepare() must be rewritten
> though I'm not sure.  

OK, I see you have applied your patch:
	
	1) [ODBC] Psqlodbc and Centura: here it is a patch
	        posted by Matteo Cavalleli
	2) [ODBC] pgsqODBC binding parameters II
	        posted by Ludek Finstrle
	3) Invalid Page Fault in PSQLODBC.DLL
	        personal mail from Johann Zuschlag

I removed it from the outstanding patches page.  

And you are saying that this patch fixes a different problem.  The user
reported his problems were fixed by that patch, so I am inclined to
apply it.

Thanks.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026