From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200106041832.f54IWHD00108@candle.pha.pa.us>
Subject: Re: [INTERFACES] libpq sockets on win32
In-Reply-To: <6675.991679378@sss.pgh.pa.us> "from Tom Lane at Jun 4,
	2001 02:29:38 pm"
To: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 4 Jun 2001 14:32:17 -0400 (EDT)
CC: jeff@jeffjohnson.net, pgsql-interfaces@postgresql.org,
	pgsql-docs@postgresql.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII

> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >> This article describes the problem and work around.
> >> http://msdn.microsoft.com/library/psdk/winsock/ovrvw3_26ia.htm
> 
> > I can't read that web site under Netscape.
> 
> Comes up fine for me (maybe you need to turn off Javascript?)

Thanks, that fixed it.

> However, the advice on it seems to be written by someone who does not
> know the difference between a variable and a function :-(.  Read with
> a large grain of salt.
> 
> We already have a couple of #ifdef'd usages of WSAGetLastError() in
> libpq, but it's quite unclear which other references to errno might
> need to be changed.  A blanket replacement of errno would certainly
> break things.

That's why I recommended brackets of #define/#undef around tests of
socket errno's.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026