Received: from candle.pha.pa.us (216-55-132-35.dsl.san-diego.abac.net [216.55.132.35]) by postgresql.org (Postfix) with ESMTP id 59BC6476319 for ; Thu, 11 Apr 2002 17:42:09 -0400 (EDT) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.10.1) id g3BLg6908782; Thu, 11 Apr 2002 17:42:06 -0400 (EDT) From: Bruce Momjian Message-Id: <200204112142.g3BLg6908782@candle.pha.pa.us> Subject: Re: libpgtcl pg_execute In-Reply-To: To: ljb Date: Thu, 11 Apr 2002 17:42:06 -0400 (EDT) Cc: pgsql-interfaces@postgresql.org X-Mailer: ELM [version 2.4ME+ PL97 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Archive-Number: 200204/20 X-Sequence-Number: 2562 This was applied March 4. I was not sure you had been informed so I am sending this email. --------------------------------------------------------------------------- ljb wrote: > tgl@sss.pgh.pa.us wrote: > > > Looking at the CVS logs, I see that Jan added this command; he should be > > blamed for not having added any documentation. Feel free to contribute > > a documentation patch ... > > I have documentation, but just as plain text. Unfortunately I don't have > the tools or know-how to get it (correctly) into SGML at this time. > What should I do? > > > What's wrong with the -oid code? > > pg_execute throws an error when you use -oid (with no error message), because > the return value check on Tcl_SetVar is wrong. Here's the fix: > > *** src/interfaces/libpgtcl/pgtclCmds.c.orig Mon Dec 3 09:49:46 2001 > --- src/interfaces/libpgtcl/pgtclCmds.c Mon Feb 18 17:25:27 2002 > *************** > *** 909,915 **** > > sprintf(oid_buf, "%u", PQoidValue(result)); > if (Tcl_SetVar(interp, oid_varname, oid_buf, > ! TCL_LEAVE_ERR_MSG) != TCL_OK) > { > PQclear(result); > return TCL_ERROR; > --- 909,915 ---- > > sprintf(oid_buf, "%u", PQoidValue(result)); > if (Tcl_SetVar(interp, oid_varname, oid_buf, > ! TCL_LEAVE_ERR_MSG) == NULL) > { > PQclear(result); > return TCL_ERROR; > > ---------------------------(end of broadcast)--------------------------- > TIP 6: Have you searched our list archives? > > http://archives.postgresql.org > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026