Date: Mon, 18 Nov 2002 17:33:56 +0000
From: Tim Bunce <Tim.Bunce@pobox.com>
To: David Wheeler <david@wheeler.net>
Cc: Tim Bunce <Tim.Bunce@pobox.com>, dbi-dev@perl.org,
	pgsql-interfaces@postgresql.org
Subject: Re: DBD::PostgreSQL
Message-ID: <20021118173356.GE1444@dansat.data-plan.com>
References: <20021118101554.GU1408@dansat.data-plan.com>
	<85B2FBF1-FB16-11D6-93B3-0003931A964A@wheeler.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <85B2FBF1-FB16-11D6-93B3-0003931A964A@wheeler.net>
User-Agent: Mutt/1.4i

On Mon, Nov 18, 2002 at 08:55:20AM -0800, David Wheeler wrote:
> On Monday, November 18, 2002, at 02:15  AM, Tim Bunce wrote:
> 
> Okay, then that's what I'll do. Do I check it like this?
> 
>   if (DBIc_has(imp_dbh, DBIcf_BegunWork)) {...}

Yeap.

> >>* Also in dbd_db_commit() and dbd_db_rollback(), I notice that the 
> >>last
> >>return statement returns 0. Shouldn't these be returning true?
> >
> >Yes, when using Driver.xst, if there's no error.
> 
> It appears that they return false when imp_dbh->conn is NULL. That 
> would count as an error, I think. DBD::Pg doesn't report it as an 
> error, though -- it just returns false. Should I add an appropriate 
> call to do_error() in such a case?

Probably. It's fairly important that a method doesn't return an error
status without having recorded the error by at least doing
	sv_setiv(DBIc_ERR(imp_xxh), ...)

> >I'd really appreciate any feedback (ie patches :) you might have
> >for the DBI::DBD document.  It's a bit thin and/or dated in places.
> 
> Yes, I've thought about that. You can at least expect a bit of clean up 
> (grammar, etc.), but I might well add more. It'd probably be good to do 
> so as a newbie who wants to help other newbies along...

Great. Thanks.

Tim.