X-Original-To: pgsql-interfaces@postgresql.org Received: from candle.pha.pa.us (momjian.navpoint.com [207.106.42.251]) by postgresql.org (Postfix) with ESMTP id 02783475F16 for ; Thu, 20 Mar 2003 14:09:34 -0500 (EST) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.10.1) id h2KJ9QU02834; Thu, 20 Mar 2003 14:09:26 -0500 (EST) From: Bruce Momjian Message-Id: <200303201909.h2KJ9QU02834@candle.pha.pa.us> Subject: Re: I want to send comments to the backend! In-Reply-To: <25200.1048186822@sss.pgh.pa.us> To: Tom Lane Date: Thu, 20 Mar 2003 14:09:26 -0500 (EST) Cc: =?ISO-8859-1?Q?Gerhard_H=E4ring?= , pgsql-interfaces@postgresql.org X-Mailer: ELM [version 2.4ME+ PL99 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Archive-Number: 200303/106 X-Sequence-Number: 3855 Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> generalize it to understand about comments. Right now seems to be a > >> fine time to think about this, in fact, given that we're hacking the > >> protocol anyway. > > > Yes. > > On third thought, though, it would be really trivial for > pg_exec_query_string to call NullCommand and fall out early if > pg_parse_query returns an empty list; it'd take one extra test for NIL, > which would be more than compensated for if we got rid of the strspn > test. So maybe changing the backend is the best answer after all. Yes, that was my original thought. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073