X-Original-To: pgsql-interfaces@postgresql.org Received: from candle.pha.pa.us (momjian.navpoint.com [207.106.42.251]) by postgresql.org (Postfix) with ESMTP id 03FBD476363 for ; Fri, 21 Mar 2003 01:00:16 -0500 (EST) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.10.1) id h2L5xv110719; Fri, 21 Mar 2003 00:59:57 -0500 (EST) From: Bruce Momjian Message-Id: <200303210559.h2L5xv110719@candle.pha.pa.us> Subject: Re: I want to send comments to the backend! In-Reply-To: <10177.1048225294@sss.pgh.pa.us> To: Tom Lane Date: Fri, 21 Mar 2003 00:59:56 -0500 (EST) Cc: =?ISO-8859-1?Q?Gerhard_H=E4ring?= , pgsql-interfaces@postgresql.org X-Mailer: ELM [version 2.4ME+ PL99 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Archive-Number: 200303/112 X-Sequence-Number: 3861 I now understand that IsUnderPostmaster isn't needed, as you suggested below. --------------------------------------------------------------------------- Tom Lane wrote: > Bruce Momjian writes: > > OK, this patch fixes the comment passing bug. I remove the strspn() and > > added a boolean to test if any parsetree had been generated --- if not, > > I call NullCommand(). > > Seems like the hard way. I had in mind a quick > > if (parsetree_list == NIL) > { > NullCommand(dest); > return; > } > > before entering the main loop. It'd take a small amount of reordering > of the existing code to make this happen without adding any more code > than that, but it looked doable. > > regards, tom lane > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073