X-Original-To: pgsql-patches@postgresql.org Received: from localhost (developer.postgresql.org [64.117.224.193]) by developer.postgresql.org (Postfix) with ESMTP id 9D7D2925036 for ; Mon, 26 May 2003 13:06:44 -0400 (EDT) Received: from developer.postgresql.org ([64.117.224.193]) by localhost (developer.postgresql.org [64.117.224.193:10024]) (amavisd-new) with ESMTP id 38335-09 for ; Mon, 26 May 2003 13:06:44 -0400 (EDT) Received: from candle.pha.pa.us (momjian.navpoint.com [207.106.42.251]) by developer.postgresql.org (Postfix) with ESMTP id DAB4A925025 for ; Mon, 26 May 2003 13:06:42 -0400 (EDT) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.11.6) id h4QH6aB06687; Mon, 26 May 2003 13:06:36 -0400 (EDT) From: Bruce Momjian Message-Id: <200305261706.h4QH6aB06687@candle.pha.pa.us> Subject: Re: [HACKERS] ECPG thread-safety In-Reply-To: <200303282226.20016.shridhar_daithankar@nospam.persistent.co.in> To: Shridhar Daithankar Date: Mon, 26 May 2003 13:06:36 -0400 (EDT) Cc: PostgreSQL-patches X-Mailer: ELM [version 2.4ME+ PL99 (25)] MIME-Version: 1.0 Content-Type: multipart/mixed; boundary=ELM1053968796-5595-1_ Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new X-Archive-Number: 200305/138 X-Sequence-Number: 7081 --ELM1053968796-5595-1_ Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Shridhar Daithankar wrote: > On Friday 28 March 2003 21:45, you wrote: > > For testing the library, I think it is enough to init an thread attr. like > > pthread_init_attr, that should be enough to test header and library. > > And compiler flags, I forgot.. -pthread on freeBSD/gcc and -D_REENTRANT on > linux at least. FreeBSD needs _THREAD_SAFE as well IIRC. Are you saying FreeBSD actually has a -pthread compiler flag? And Linux needs REENTRANT. We can do that. Here is an updated patch. Of course, I need to run autoconf too. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 --ELM1053968796-5595-1_ Content-Transfer-Encoding: 7bit Content-Type: text/plain Content-Disposition: inline; filename="/pgpatches/threads" Index: configure.in =================================================================== RCS file: /cvsroot/pgsql-server/configure.in,v retrieving revision 1.253 diff -c -c -r1.253 configure.in *** configure.in 22 May 2003 16:39:28 -0000 1.253 --- configure.in 26 May 2003 17:05:52 -0000 *************** *** 506,511 **** --- 506,514 ---- [ --without-zlib do not use Zlib]) + # + # Elf + # # Assume system is ELF if it predefines __ELF__ as 1, # otherwise believe host_os based default. *************** *** 527,533 **** --- 530,560 ---- fi]) AC_SUBST(ELF_SYS) + # + # Pthreads + # + AC_CHECK_HEADER(pthread.h, + [AC_DEFINE(HAVE_THREADS, 1, [Define to 1 if you have the threads interface.])]) + if test ! -z "$HAVE_THREADS" + then + case $host_os in + # BSD/OS and NetBSD require no special libraries or flags + netbsd*|bsdi*) ;; + freebsd*) THREAD_LIBS="-lc_r" + THREAD_CFLAGS="-pthread" ;; + linux*) THREAD_LIBS="-lpthread" + THREAD_CFLAGS="-D_REENTRANT" ;; + # other operating systems might fail because they have pthread.h but need + # special libs we don't know about yet. + esac + fi + AC_SUBST(THREAD_LIBS) + AC_SUBST(THREAD_CFLAGS) + + # + # Assignments + # CPPFLAGS="$CPPFLAGS $INCLUDES" LDFLAGS="$LDFLAGS $LIBDIRS" Index: src/Makefile.global.in =================================================================== RCS file: /cvsroot/pgsql-server/src/Makefile.global.in,v retrieving revision 1.162 diff -c -c -r1.162 Makefile.global.in *** src/Makefile.global.in 11 May 2003 20:50:53 -0000 1.162 --- src/Makefile.global.in 26 May 2003 17:05:54 -0000 *************** *** 152,157 **** --- 152,160 ---- TK_LIB_SPEC = @TK_LIB_SPEC@ TK_XINCLUDES = @TK_XINCLUDES@ + THREAD_CFLAGS = @THREAD_CFLAGS@ + THREAD_LIBS = @THREAD_LIBS@ + have_docbook = @have_docbook@ DOCBOOKSTYLE = @DOCBOOKSTYLE@ COLLATEINDEX = @COLLATEINDEX@ Index: src/include/pg_config.h.in =================================================================== RCS file: /cvsroot/pgsql-server/src/include/pg_config.h.in,v retrieving revision 1.47 diff -c -c -r1.47 pg_config.h.in *** src/include/pg_config.h.in 22 May 2003 16:39:30 -0000 1.47 --- src/include/pg_config.h.in 26 May 2003 17:05:56 -0000 *************** *** 465,470 **** --- 465,473 ---- /* Define to 1 if you have the header file. */ #undef HAVE_TERMIOS_H + /* Define to 1 if you have the header file. */ + #undef HAVE_THREADS + /* Define to 1 if your `struct tm' has `tm_zone'. Deprecated, use `HAVE_STRUCT_TM_TM_ZONE' instead. */ #undef HAVE_TM_ZONE --ELM1053968796-5595-1_--