Date: Fri, 30 May 2003 15:03:13 +0100
From: Tim Bunce <Tim.Bunce@pobox.com>
To: Dominic Mitchell <dom@semantico.com>
Cc: Tim Bunce <Tim.Bunce@pobox.com>, Rudy Lippan <rlippan@remotelinux.com>,
	Bruce Momjian <pgman@candle.pha.pa.us>,
	David Wheeler <david@wheeler.net>, pgsql-interfaces@postgresql.org,
	"'DBI developers'" <dbi-dev@perl.org>
Subject: Re: DBD::Pg 1.30_1 WAS (Re: Prepare and prepare ?)
Message-ID: <20030530140313.GP6818@dansat.data-plan.com>
References: <Pine.LNX.4.44.0305290446550.26451-100000@elfride.ineffable.net>
	<3ED5CC25.70102@semantico.com>
	<20030530090401.GG6818@dansat.data-plan.com>
	<3ED7224B.7030101@semantico.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3ED7224B.7030101@semantico.com>
User-Agent: Mutt/1.4i

On Fri, May 30, 2003 at 10:20:11AM +0100, Dominic Mitchell wrote:
> Tim Bunce wrote:
> >On Thu, May 29, 2003 at 10:00:21AM +0100, Dominic Mitchell wrote:
> >
> >>One more thing for the change log:  notice messages generated by the 
> >>database now use the perl warning mechanism instead of going to stderr, 
> >>so they can be trapped if needed.
> >
> >
> >Hopefully implemented as
> >
> >	if (DBIc_WARN(imp_xxh))
> >	    warn("...", ...)
> >
> >The $h->{Warn} attribute defaults to true. Can be useful to silence
> >warnings for a handle without having to play games with $SIG{__WARN__}.
> 
> See, I told you I wasn't an XS guru.  :-)
> 
> Actually, I looked at this, but my limited C and DBI skills couldn't 
> work out a) what the required handle was (probably dbh)

Just whatever handle was used to call the method that's generating the warning.

> and b) how to pass that into the PQsetNoticeProcessor function as data
> and get it out again.

Ah, different issue. For that I'd say if DBIc_WARN(imp_xxh) isn't true
then disable the PQsetNoticeProcessor function.

> I'll happily take another look though, now that it's been brought up as 
> desirable.

Actually I'd misunderstood the circumstances of the warn (not reading
your message carefully enough). For notice messages generated by
the database server they'll soon(ish) be a $h->{HandleEvent} = sub { ... }
hook that should be used.

But that'll bring you back to needing some way for the PQsetNoticeProcessor
function to get at the handle data it'll need to pass to the HandleEvent
hook. The PQsetNoticeProcessor API ought to allow you to some way to do that.

Tim.