X-Original-To: pgsql-interfaces-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 18B9C528B7; Mon, 4 Jul 2005 16:06:01 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 80307-09; Mon, 4 Jul 2005 19:05:58 +0000 (GMT) Received: from candle.pha.pa.us (candle.pha.pa.us [64.139.89.126]) by svr1.postgresql.org (Postfix) with ESMTP id E74BF5288D; Mon, 4 Jul 2005 16:05:56 -0300 (ADT) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.11.6) id j64J5v012606; Mon, 4 Jul 2005 15:05:57 -0400 (EDT) From: Bruce Momjian Message-Id: <200507041905.j64J5v012606@candle.pha.pa.us> Subject: Re: libecpg (8.0 and CVS) hits a gcc bug on powerpc In-Reply-To: <42B190A6.7010409@petig-baender.de> To: Christof Petig Date: Mon, 4 Jul 2005 15:05:57 -0400 (EDT) Cc: Michael Meskes , pgsql-patches@postgresql.org, Interfaces X-Mailer: ELM [version 2.4ME+ PL121 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.009 tagged_above=0 required=5 tests=AWL X-Spam-Level: X-Archive-Number: 200507/2 X-Sequence-Number: 5638 Patch applied. Thanks. --------------------------------------------------------------------------- Christof Petig wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Michael Meskes schrieb: > > Patch committed. Thanks. > > I have to admit that I got the case of the preprocessor symbol on amd64 > wrong. __AMD64__ is not defined, __amd64__ is. > > Sorry, corrected patch attached > Christof > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.1 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org > > iD8DBQFCsZCmng+R+0ucfO0RAoABAKDKnokBW+tgXMKgeEMecpZsFXRFTQCeKeBu > YsdWP056cqxKtNAx5Gh/Wis= > =b2Og > -----END PGP SIGNATURE----- [ text/x-patch is unsupported, treating like TEXT/PLAIN ] > Index: src/interfaces/ecpg/ecpglib/execute.c > =================================================================== > RCS file: /projects/cvsroot/pgsql/src/interfaces/ecpg/ecpglib/execute.c,v > retrieving revision 1.40 > diff -u -u -r1.40 execute.c > --- src/interfaces/ecpg/ecpglib/execute.c 2 Jun 2005 12:35:11 -0000 1.40 > +++ src/interfaces/ecpg/ecpglib/execute.c 16 Jun 2005 14:35:09 -0000 > @@ -70,7 +70,7 @@ > return res; > } > > -#if defined(__GNUC__) && (defined (__powerpc__) || defined(__AMD64__) || defined(__x86_64__)) > +#if defined(__GNUC__) && (defined (__powerpc__) || defined(__amd64__) || defined(__x86_64__)) > #define APREF ap > #else > #define APREF *ap > @@ -178,7 +178,7 @@ > if (!(var = (struct variable *) ECPGalloc(sizeof(struct variable), lineno))) > return false; > > -#if defined(__GNUC__) && (defined (__powerpc__) || defined(__AMD64__) || defined(__x86_64__)) > +#if defined(__GNUC__) && (defined (__powerpc__) || defined(__amd64__) || defined(__x86_64__)) > ECPGget_variable(ap, type, var, true); > #else > ECPGget_variable(&ap, type, var, true); > Index: src/interfaces/ecpg/ecpglib/extern.h > =================================================================== > RCS file: /projects/cvsroot/pgsql/src/interfaces/ecpg/ecpglib/extern.h,v > retrieving revision 1.13 > diff -u -u -r1.13 extern.h > --- src/interfaces/ecpg/ecpglib/extern.h 2 Jun 2005 12:35:11 -0000 1.13 > +++ src/interfaces/ecpg/ecpglib/extern.h 16 Jun 2005 14:35:09 -0000 > @@ -125,7 +125,7 @@ > bool ECPGstore_result(const PGresult *results, int act_field, > const struct statement * stmt, struct variable * var); > bool ECPGstore_input(const int, const bool, const struct variable *, const char **, bool *); > -#if defined(__GNUC__) && (defined (__powerpc__) || defined(__AMD64__) || defined(__x86_64__)) > +#if defined(__GNUC__) && (defined (__powerpc__) || defined(__amd64__) || defined(__x86_64__)) > // work around a gcc/ABI bug with va_lists on ppc+amd64 > void ECPGget_variable(va_list, enum ECPGttype, struct variable *, bool); > #else > > ---------------------------(end of broadcast)--------------------------- > TIP 6: Have you searched our list archives? > > http://archives.postgresql.org -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073