From: Michael Meskes <meskes@postgresql.org>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Subject: Re: [BUGS] BUG #2171: Differences compiling plpgsql in ecpg and psql
Date: Thu, 9 Feb 2006 09:14:56 +0100
User-Agent: KMail/1.9.1
Cc: andrew5@ece.cmu.edu, PostgreSQL-patches <pgsql-patches@postgresql.org>,
	PostgreSQL-interfaces <pgsql-interfaces@postgresql.org>
References: <200602070140.k171eIY00569@candle.pha.pa.us>
In-Reply-To: <200602070140.k171eIY00569@candle.pha.pa.us>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200602090914.58790.meskes@postgresql.org>

> > Actually ecpg should not translate dollar quoting at all. I'm going to
> > fix this. Dollar quotes will then be send to the backend with
> > translation and the backend takes care of the rest.
>
> Well, CVS version before I modified it had "dolq" stuff in the lexer to
> handle dollar quotes and pass it as SCONST to the parser.

Yes, I know. This was buggy from the get go on IMO. :-)

> > Not sure, but there appears to be a bug in the routine that outputs a
> > statement. I will change that one as well and would ask you to just
> > check again. It seems to me that this also fixes your problem. I tried
> > with the one test case in this email and it seems to work. But then I'm
> > currently travelling and do not have that much spare time to test.
>
> The problem is that output.c does:
>
> 	printf("abc
> 	def");
>
> While some compilers are OK with that, others are not.  I changed it to
> output:
>
> 	printf("abc\n\
> 	def");

Okay, will look into this again. 

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!