pg.ddx.io pgsql-interfaces@postgresql.org mailing list archive
help / color / mirror / Atom feedRe: Antwort: Patches for gram.y and keywords.c
2+ messages / 1 participants
[nested] [flat]
* Re: Antwort: Patches for gram.y and keywords.c
@ 1998-09-30 15:28 Thomas G. Lockhart <lockhart@alumni.caltech.edu>
0 siblings, 1 reply; 2+ messages in thread
From: Thomas G. Lockhart @ 1998-09-30 15:28 UTC (permalink / raw)
To: Michael Meskes <Michael.Meskes@usa.net>; +Cc: pgsql-interfaces
> Okay, here's the patch for ecpg...
> It contains other changes I made that haven't made it into the archive
> yet. Could you please put all this into cvs?
Hi Michael. I got the patches and they all applied cleanly. I notice
that there might be several keywords missing from your version of
keywords.c (I had done some updates recently that I forgot to let you
know about):
> {"absolute", ABSOLUTE},
> {"encoding", ENCODING},
> {"names", NAMES},
> {"next", NEXT},
> {"old", CURRENT},
> {"only", ONLY},
> {"prior", PRIOR},
> {"read", READ},
> {"relative", RELATIVE},
> {"scroll", SCROLL},
> {"serial", SERIAL},
It seems simple to make the changes to make this compatible with the
newest version of parser/keywords.c; should I go ahead and do that?
Since the only difference between the files is in which files are
mentioned in the #includes at the top, I was going to suggest changing
parser/keywords.c to have something like:
#ifdef ECPG
#include "type.h"
#include "y.tab.h"
#else
#include "parse.h"
#endif
But I think that is not the best idea since it might make preproc.y and
your keywords.c inconsistant at times. OK, never mind: it's a bad idea
:)
So, should I update your keywords.c to add the missing entries? It looks
like at least one entry (NEXT) does not appear in the keywords files but
does appear in preproc.y already. Probably doesn't get recognized
though...
- Tom
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Antwort: Patches for gram.y and keywords.c
@ 1998-10-03 05:23 Thomas G. Lockhart <lockhart@alumni.caltech.edu>
parent: Thomas G. Lockhart <lockhart@alumni.caltech.edu>
0 siblings, 0 replies; 2+ messages in thread
From: Thomas G. Lockhart @ 1998-10-03 05:23 UTC (permalink / raw)
To: Michael Meskes <meskes@usa.net>; +Cc: Postgres Hackers List <hackers@postgresql.org>
> will you apply my patches to the cvs tree, too? Since we will release
> 6.4 pretty soon I think the changes should make it into the tree asap.
Applied.
These patches from Michael bring the ecpg parser up to date with the
main Postgres parser, as well as solidifying some strdup() usage.
- Tom
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~1998-10-03 05:23 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
1998-09-30 15:28 Re: Antwort: Patches for gram.y and keywords.c Thomas G. Lockhart <lockhart@alumni.caltech.edu>
1998-10-03 05:23 ` Thomas G. Lockhart <lockhart@alumni.caltech.edu>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox