Received: from sd.tpf.co.jp (sd.tpf.co.jp [210.161.239.34]) by postgresql.org (8.11.3/8.11.1) with SMTP id f491BWA30020 for ; Tue, 8 May 2001 21:11:32 -0400 (EDT) (envelope-from Inoue@tpf.co.jp) Received: (qmail 28120 invoked from network); 9 May 2001 01:11:27 -0000 Received: from unknown (HELO viscomail.tpf.co.jp) (100.0.0.108) by sd2.10.0.100.in-addr.arpa with SMTP; 9 May 2001 01:11:27 -0000 Received: from tpf.co.jp (3d_note1 [126.0.1.61]) by viscomail.tpf.co.jp (8.8.8+Sun/8.8.8) with ESMTP id KAA02257; Wed, 9 May 2001 10:11:26 +0900 (JST) Message-ID: <3AF89956.47FEDBF5@tpf.co.jp> Date: Wed, 09 May 2001 10:11:50 +0900 From: Hiroshi Inoue X-Mailer: Mozilla 4.73 [ja] (Windows NT 5.0; U) X-Accept-Language: ja MIME-Version: 1.0 To: Bruce Momjian CC: Keith Millard , PostgreSQL odbc list Subject: Re: Re: [INTERFACES] Postgres odbc driver bug References: <200105081655.f48GtkL12980@candle.pha.pa.us> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-Archive-Number: 200105/47 X-Sequence-Number: 436 Bruce Momjian wrote: > > OK, I have created a context diff of your changes, which is attached. > Can someone comment on this? The patch appears to deal with > STMT_PREMATURE differently than our current code. > > In fact, it seems to disable this code: > > /* > * If the statement is premature, it means we already executed it from > * an SQLPrepare/SQLDescribeCol type of scenario. So just return > * success. > */ > if (stmt->prepare && stmt->status == STMT_PREMATURE) > Though this fixes the bug reported by Keith, STMT_PREMATURE loses its meaning and SC_pre_execute() does a non-essential work as a result. Possibly SQLPrepare() must be rewritten though I'm not sure. regards, Hiroshi Inoue