Message-ID: <3AF8A5FB.819D8A92@tpf.co.jp>
Date: Wed, 09 May 2001 11:05:47 +0900
From: Hiroshi Inoue <Inoue@tpf.co.jp>
MIME-Version: 1.0
To: Bruce Momjian <pgman@candle.pha.pa.us>
CC: Keith Millard <Kmillard@pumatech.com>,
	PostgreSQL odbc list <pgsql-odbc@postgresql.org>
Subject: Re: Re: [INTERFACES] Postgres odbc driver bug
References: <200105090153.f491rWd17938@candle.pha.pa.us>
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit

Bruce Momjian wrote:
> 
> > Bruce Momjian wrote:
> > >
> > > OK, I have created a context diff of your changes, which is
> > attached.
> > > Can someone comment on this?  The patch appears to deal with
> > > STMT_PREMATURE differently than our current code.
> > >
> > > In fact, it seems to disable this code:
> > >
> > >     /*
> > >      * If the statement is premature, it means we already executed it from
> > >      * an SQLPrepare/SQLDescribeCol type of scenario.  So just return
> > >      * success.
> > >      */
> > >     if (stmt->prepare && stmt->status == STMT_PREMATURE)
> > >
> >
> > Though this fixes the bug reported by Keith, STMT_PREMATURE
> > loses its meaning and SC_pre_execute() does a non-essential
> > work as a result. Possibly SQLPrepare() must be rewritten
> > though I'm not sure.
> 

[snip]

> 
> And you are saying that this patch fixes a different problem.  The user
> reported his problems were fixed by that patch, so I am inclined to
> apply it.
> 

I don't agree to apply the patch because the patch makes
the current code hardly understandable.

regards,
Hiroshi inoue