Received: from localhost (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id EB00B475FFE for ; Mon, 9 Dec 2002 11:12:58 -0500 (EST) Received: from sss.pgh.pa.us (unknown [192.204.191.242]) by postgresql.org (Postfix) with ESMTP id 4CDD547613C for ; Mon, 9 Dec 2002 11:03:53 -0500 (EST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.6/8.12.6) with ESMTP id gB9G3qpd008160; Mon, 9 Dec 2002 11:03:52 -0500 (EST) To: Ian Barwick Cc: dbi-dev@perl.org, pgsql-interfaces@postgresql.org Subject: Re: Patch for DBD::Pg pg_relcheck problem In-reply-to: <200212091631.00125.barwick@gmx.net> References: <200212091631.00125.barwick@gmx.net> Comments: In-reply-to Ian Barwick message dated "Mon, 09 Dec 2002 16:31:00 +0100" Date: Mon, 09 Dec 2002 11:03:52 -0500 Message-ID: <8159.1039449832@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by AMaViS new-20020517 X-Archive-Number: 200212/22 X-Sequence-Number: 3435 Ian Barwick writes: > To avoid voodoo with PostgreSQL version numbers > a check is made whether pg_relcheck exists and > the appropriate query (either 7.3 or pre 7.3) > executed. I would think that looking at version number (select version()) would be a much cleaner approach. Or do you think that direct examination of pg_class is a version-independent operation? This inquiry into pg_relcheck's existence is already arguably wrong in 7.3 (since it's not taking account of which schema pg_relcheck might be found in) and it can only go downhill in future versions. regards, tom lane