X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [64.117.224.130]) by svr1.postgresql.org (Postfix) with ESMTP id 7D675D1B531 for ; Sun, 5 Oct 2003 18:27:46 +0000 (GMT) Received: from svr1.postgresql.org ([64.117.224.193]) by localhost (neptune.hub.org [64.117.224.130]) (amavisd-new, port 10024) with ESMTP id 80834-09 for ; Sun, 5 Oct 2003 15:27:01 -0300 (ADT) Received: from sss.pgh.pa.us (unknown [192.204.191.242]) by svr1.postgresql.org (Postfix) with ESMTP id 842D7D1B51A for ; Sun, 5 Oct 2003 15:26:59 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.10/8.12.10) with ESMTP id h95IQnhn008637; Sun, 5 Oct 2003 14:26:49 -0400 (EDT) To: Bruce Momjian Cc: Peter Eisentraut , PostgreSQL Development Subject: Re: PQfnumber and quoted identifiers In-reply-to: <200310051758.h95HwL212741@candle.pha.pa.us> References: <200310051758.h95HwL212741@candle.pha.pa.us> Comments: In-reply-to Bruce Momjian message dated "Sun, 05 Oct 2003 13:58:21 -0400" Date: Sun, 05 Oct 2003 14:26:48 -0400 Message-ID: <8636.1065378408@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200310/255 X-Sequence-Number: 44937 Bruce Momjian writes: > Peter Eisentraut wrote: >> Since this behavior was undocumented and no one had noticed it in the last >> 10 years, I think we can away with removing it. > I agree. I would never expect to add quotes to a C string to preserve > case (outside SQL), and the fact that PQfname doesn't return the string > in quotes is another inconsistency. Actually I was planning to quiz you about the history. I can see from the CVS logs that you installed all the patches that added the quoting/downcasing behavior. Was there any discussion about it? I dug through the mail archives and found http://archives.postgresql.org/pgsql-ports/1997-05/msg00081.php http://archives.postgresql.org/pgsql-bugs/1997-05/msg00023.php http://archives.postgresql.org/pgsql-hackers/1997-11/msg00170.php but I could not find any actual discussion about whether there was a real bug or whether the complainants should be told to fix their code. regards, tom lane