X-Original-To: pgsql-interfaces-postgresql.org@localhost.postgresql.org
Received: from localhost (unknown [200.46.204.2])
	by svr1.postgresql.org (Postfix) with ESMTP id 24C05D1B559
	for <pgsql-interfaces-postgresql.org@localhost.postgresql.org>;
	Thu, 30 Oct 2003 09:16:07 +0000 (GMT)
Received: from svr1.postgresql.org ([200.46.204.71])
	by localhost (neptune.hub.org [200.46.204.2]) (amavisd-new, port 10024)
	with ESMTP id 14839-07
	for <pgsql-interfaces-postgresql.org@localhost.postgresql.org>;
	Thu, 30 Oct 2003 05:15:37 -0400 (AST)
Received: from skyhouseconsulting.com (unknown [216.93.161.184])
	by svr1.postgresql.org (Postfix) with ESMTP id C39E8D1B585
	for <pgsql-interfaces@postgresql.org>;
	Thu, 30 Oct 2003 05:15:34 -0400 (AST)
Received: from amadeus (mail@PPP-219-65-134-252.bng.vsnl.net.in
	[219.65.134.252])
	by skyhouseconsulting.com (8.12.10/8.12.10) with ESMTP id
	h9U9EiWp027314; Thu, 30 Oct 2003 03:14:46 -0600 (CST)
	(envelope-from jason@openinformatics.com)
Received: from jasons by amadeus with local (Exim 3.35 #1 (Debian))
	id 1AF8r7-0001Ev-00; Thu, 30 Oct 2003 14:42:37 +0530
To: Tavin Cole <tavin@agilecomputing.com>
Cc: dbi-dev@perl.org, pgsql-interfaces@postgresql.org
Subject: Re: DBD::Pg 1.22 fatal bug / patch
References: <1067504544.1441.554.camel@localhost>
From: jason@openinformatics.com (Jason E. Stewart)
Date: 30 Oct 2003 14:42:37 +0530
In-Reply-To: <1067504544.1441.554.camel@localhost>
Message-ID: <878yn39ji2.fsf@openinformatics.com>
Lines: 34
User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by amavisd-new at postgresql.org
X-Archive-Number: 200310/59
X-Sequence-Number: 4548

Hi,

I've added your patch to GBorg.

Thanks,
jas.

Tavin Cole <tavin@agilecomputing.com> writes:

> i'm running a script that uses DBD::Pg 1.22 and fails with:
> 
> Undefined subroutine &DBD::Pg::db::pg_server_version called at
> /usr/lib/perl5/site_perl/5.8.0/i686-linux/DBD/Pg.pm line 911.
> 
> this is fixed with the attached patch.  thanks for the software!
> 
> cheers
> 
> -- 
> Tavin Cole <tavin@agilecomputing.com>
> http://www.agilecomputing.com/
> 
> --- Pg.pm.bak   2003-03-26 23:28:37.000000000 -0500
> +++ Pg.pm       2003-04-20 14:28:39.000000000 -0400
> @@ -908,7 +908,8 @@
>              # by pg_constraint. To maintain compatibility, check
>              # version number and execute appropriate query.
>   
> -            my $version = pg_server_version( $dbh );
> +            #my $version = pg_server_version( $dbh );
> +            my $version = DBD::Pg::pg_server_version( $dbh );
>               
>              my $con_query = $version < 7.3
>               ? "SELECT rcsrc FROM pg_relcheck WHERE rcname = '${table}_$col_name'"