Date: 30 Nov 2002 10:47:09 -0700
Message-ID: <87k7ivt0f6.fsf@openinformatics.com>
From: "Jason E. Stewart" <jason@openinformatics.com>
To: "Dave Rolsky" <autarch@urth.org>
Cc: "David Wheeler" <david@wheeler.net>,
	pgsql-interfaces@postgresql.org, dbi-dev@perl.org
Subject: Re: ANNOUNCE: DBD::Pg 1.20
References: <84A43EBC-0235-11D7-929B-0003931A964A@wheeler.net>
	<Pine.LNX.4.50.0211291336140.29663-100000@urth.org>
In-Reply-To: <Pine.LNX.4.50.0211291336140.29663-100000@urth.org>
Lines: 34
User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

"Dave Rolsky" <autarch@urth.org> writes:

> I found a bug in the ->tables method.  It includes all the system tables.
> A patch is at the bottom of the message.

Thanks Dave,

> The SQL was correct in 1.13 so I'm not sure how this happened.  There's
> also no real test of this method in the test suite, other than testing to
> make sure that calling it doesn't die.  But you need to test that it
> returns the right thing too ;)
> 
> I'd like to offer a test patch but I don't know exactly what you'd expect
> to find in the schema during testing.

t/01setup.t has the following:

  my $sql = <<SQL;
  CREATE TABLE test (
    id int,
    name text,
    val text,
    score float,
    date timestamp default 'now()'
  )
  SQL

You can expect that table to exist. Also, you could create a couple of
more tables/views and test that as well.

Cheers,
jas.

PS. Thanks for the Mason book, I'm enjoying it.