Received: from localhost (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id EF78C475AAC for ; Wed, 27 Nov 2002 05:46:38 -0500 (EST) Received: from mpls-qmqp-04.inet.qwest.net (mpls-qmqp-04.inet.qwest.net [63.231.195.115]) by postgresql.org (Postfix) with SMTP id 09759474E53 for ; Wed, 27 Nov 2002 05:46:38 -0500 (EST) Received: (qmail 29873 invoked by uid 0); 27 Nov 2002 10:42:10 -0000 Received: from unknown (63.231.195.4) by mpls-qmqp-04.inet.qwest.net with QMQP; 27 Nov 2002 10:42:10 -0000 Received: from albqdslgw1poolb164.albq.uswest.net (HELO amadeus) (63.227.105.164) by mpls-pop-04.inet.qwest.net with SMTP; 27 Nov 2002 10:46:39 -0000 Received: from jasons by amadeus with local (Exim 3.35 #1 (Debian)) id 18GziE-0000Fk-00; Wed, 27 Nov 2002 03:46:34 -0700 Date: 27 Nov 2002 03:46:34 -0700 Message-ID: <87u1i3guid.fsf@openinformatics.com> From: "Jason E. Stewart" To: "Jason E. Stewart" Cc: "Bruce Momjian" , "PostgreSQL-development" , "PostgreSQL-interfaces" , david@wheeler.net Subject: Re: Interface update for 7.3 References: <200211270456.gAR4uR911735@candle.pha.pa.us> <873cpnidav.fsf@openinformatics.com> In-Reply-To: <873cpnidav.fsf@openinformatics.com> Lines: 43 User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by AMaViS new-20020517 X-Archive-Number: 200211/124 X-Sequence-Number: 3372 "Jason E. Stewart" writes: > "Bruce Momjian" writes: > > > I am working with David Wheeler on DBD:pg and hope to have a release > > packaged up tomorrow. > > Bruce, David, > > I'm updating all the test scripts to properly use the standard DBI > testing env vars, e.g. DBI_DSN, DBI_USER, DBI_PASS, and to use > Test::More. > > I've finished and committed half of them, I'll let you know when I'm > done. Ok, all done. All tests now use standard DBI vars and Test::More. All tests pass. David, could you take a look at 11quoting.t? I'm pretty sure you wrote this test (didn't you?). I converted the array of tests to a hash table so that I could give them names. However, I could only give the tests names like 'one', 'two', etc. Perhaps you can think of something more descriptive. The names are a really nice feature of Test::More. When you run the test files individually it prints out: 1..8 ok 1 - connect with transaction ok 2 - three: \ -> expected '\134' got '\134' ok 3 - five: \'?: -> expected '\134\047?:' got '\134\047?:' ok 4 - one: ' -> expected '\047' got '\047' ok 5 - two: '' -> expected '\047\047' got '\047\047' ok 6 - four: \' -> expected '\134\047' got '\134\047' ok 7 - SQL_BINARY ok 8 - disconnect So that you can find a test by name when it fails. Cheers, jas.