Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2YSn-00074x-Vh for pgsql-interfaces@arkaria.postgresql.org; Mon, 03 Aug 2020 11:17:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k2YSm-0000uZ-QJ for pgsql-interfaces@arkaria.postgresql.org; Mon, 03 Aug 2020 11:17:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2YSm-0000uR-Kd for pgsql-interfaces@lists.postgresql.org; Mon, 03 Aug 2020 11:17:04 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2YSf-0000uH-2s for pgsql-interfaces@postgresql.org; Mon, 03 Aug 2020 11:17:03 +0000 Received: from feivel.credativ.lan ([62.154.226.94]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MVrXh-1k9sjB2dmv-00RqpI; Mon, 03 Aug 2020 13:16:52 +0200 Received: from localhost (localhost [127.0.0.1]) by feivel.credativ.lan (Postfix) with ESMTP id E4D8AE0105; Mon, 3 Aug 2020 13:16:48 +0200 (CEST) Message-ID: <9e6e15313816495fc9a5d452458351a1f095d7a6.camel@postgresql.org> Subject: Re: ecpg: issue related to preprocessor directives From: Michael Meskes To: Tom Lane , Ashutosh Sharma Cc: pgsql-interfaces@postgresql.org Date: Mon, 03 Aug 2020 13:16:48 +0200 In-Reply-To: <1925404.1596292531@sss.pgh.pa.us> References: <1853327.1596240391@sss.pgh.pa.us> <1925404.1596292531@sss.pgh.pa.us> Organization: PostgreSQL Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:cb6JhqpHx4qpa6oEgHQYgCk3F7Hy+wlkvJvc1ZD4lM0jaumSIsX Qygo2VypGzsG7nePkQcxhep9CEXkxuDTcZ00P+bvxljhJrkZ8fYhfDuV/Z3uNRF7dm2ZYbh TKv/2XU+rzwPvxdqL+NZV1ta6WuhLNidmnNSTBiGXVJD0jpqYRxltP8MCk23bY0ASXH6+ZB hrxsmecLWm73H+obpEEXQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:H82azyrlPOk=:dtR8ZPwc9wVjiMrpho9BH4 5pD0l+kxaDiODj/T5j6JXquB1YGQPszIP3Az85cCgev2Y26jEeKfE/jyNQAcds/y1R1f+99k9 OuLzfs+u88MGgMQys6gX3h4mVv3xiG8NoHzw+Ou7iAXxjVYRcJotpSkwjDM/A9qCLobT/Bx95 +mcjGBC73HFtegRHShMUtFFrFDR3vYJuneuY+n+T/iL++urFCEWEKG+H4hEd5u5V3+sqs/41A T9lFgYJDlersU1TDZ2H2rLhvNIJKZcXP3QW5e1cR/VqTax8LlK7gZHy6M0brI4wRRUp8QokCT j+ODuQyXY+NsVEzqbd/QL2nbvAgedJzasJcOJEfZEuxcgr5c60IG02TM6dGm6fFheZ9RpkVgq u6ll8VLjbUfBgIRSkz57hWb4PMDbu7KIU5RRrXL5iJJ+rO/4g9JmVanUgWzzTnq+OJjSsNmkQ 0N97mOknsOGozvmpDPtClo95LVZqZ3jnD7YSNcVyIT/1zDiFJyJJ3zJBsyL+jLf1YZufVExKm YEjzJqt/g5/NQOEkqM8neRM3zjcn6/+jGa/PaXtRbEYdCzHmw9jNInA036fkzV3WdjM0VEzbB 8vN4JBOQ/BBWEIH6cZTAxw9eLE/BOHVPPZCbY5p69Xk/TNpBoZpXCUPvi3gNQzLwe559xyqrr XT/ULygqf+EVm8FwMBVVicJNV59oxcMagMU9CsfCkOYyqTeICXmwdg3X8UE2S/YLOJAGZubYW X0DYeU6TmYj0L6J0rSW2ktezoXmBM4nCq0X4/ISmHWVsxdpgNurO83UsufDzj1F9Vk9ME7a7h fjp7O8QIxN/A/F+Qyq+HRhVC+z+UYykqEu650mScv9/qJpjd7SfG5xTb8+ups1wP9/2TL8p List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk > Here's a proposed patch, which also clarifies the documentation, > which seemed a bit confused/misleading to me. Thanks Tom. > As stated, I'm not sure it's wise to back-patch this aggressively > ... but maybe it'd be okay to squeeze it into v13? Fully agreed, back-patching sounds like a pretty risky approach. I guess almost everyone who ran into this, fixed their code to work correctly by now. I'd also prefer squeezing it into 13, let's not keep this around for longer. Michael -- Michael Meskes Michael at Fam-Meskes dot De Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org