MIME-Version: 1.0
From: Ashutosh Sharma <ashu.coek88@gmail.com>
Date: Mon, 7 Sep 2020 19:17:58 +0530
Message-ID: 
 <CAE9k0PkORqHHGKY54-sFyDpP90yAf+05Auc4fs9EAn4J+uBeUQ@mail.gmail.com>
Subject: #include <stdlib.h> present twice in define.pgc
To: pgsql-interfaces@postgresql.org
Cc: Michael Meskes <meskes@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000008c5f905aeb978cd"
Precedence: bulk

--00000000000008c5f905aeb978cd
Content-Type: text/plain; charset="UTF-8"

Hi All,

I could see that the #include <stdlib.h> statement is present twice in the
define.pgc test file. See below:

[ashu@localhost postgresql]$ head
src/interfaces/ecpg/test/preproc/define.pgc
#include <stdlib.h>
#include <string.h>
#include <stdlib.h>
#include <stdio.h>

exec sql include ../regression;

...
...

Should we consider removing one of them?

I know that there won't be multiple inclusion of the same header file
because of #ifndef and #define pre-processor directives which defines
_STDLIB_H macro that allows the file to included just once, but I still
feel that it is better to avoid having such things. It doesn't do any harm
but is certainly not required. Thoughts?

-- 
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

--00000000000008c5f905aeb978cd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi All,<br><br>I could see that the #include &lt;stdlib.h&=
gt; statement is present twice in the define.pgc test file. See below:<br><=
br>[ashu@localhost postgresql]$ head src/interfaces/ecpg/test/preproc/defin=
e.pgc<br>#include &lt;stdlib.h&gt;<br>#include &lt;string.h&gt;<br>#include=
 &lt;stdlib.h&gt;<br>#include &lt;stdio.h&gt;<br><br>exec sql include ../re=
gression;<br><br>...<br>...<br><br>Should we consider removing one of them?=
<br><br>I know that there won&#39;t be multiple inclusion of the same heade=
r file because of #ifndef and #define pre-processor directives which define=
s _STDLIB_H macro that allows the file to included just once, but I still f=
eel that it is better to avoid having such things. It doesn&#39;t do any ha=
rm but is certainly not required. Thoughts?<br><div><br></div><div>-- <br>W=
ith Regards,<br>Ashutosh Sharma<br>EnterpriseDB:<a href=3D"http://www.enter=
prisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br></div></d=
iv>

--00000000000008c5f905aeb978cd--