MIME-Version: 1.0
From: Ashutosh Sharma <ashu.coek88@gmail.com>
Date: Mon, 31 Aug 2020 18:23:51 +0530
Message-ID: 
 <CAE9k0Pm-N4eFidk9Mg_ZhdLzGhPRth4K+Zgaigo44EsLX276Jg@mail.gmail.com>
Subject: ecpg: the comments inside the declare section are not outputted
 correctly.
To: pgsql-interfaces@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000a116e805ae2be580"
Precedence: bulk

--000000000000a116e805ae2be580
Content-Type: text/plain; charset="UTF-8"

Hi All,

While working on some other issue, I noticed that the comments inside the
declare section are not outputted correctly. Have a look at the below
example and its output.

void main(void)
{
exec sql begin declare section;
    int v1 = 100;
/* First Layer */
#ifdef MACRO1
/* Second Layer */
#ifdef MACRO2
   int testVar = 2;
#endif
#endif
exec sql end declare section;

    return 1;
}

*Output:*

void main(void)
{
/* exec sql begin declare section */

/* First Layer *//* Second Layer */
#line 4 "test.pgc"
 int v1 = 100 ;

#ifdef MACRO1

#ifdef MACRO2

#line 9 "test.pgc"
 int testVar = 2 ;

#endif
 #endif
/* exec sql end declare section */
#line 12 "test.pgc"


    return 1;
}

If you see the output, the comments present inside the input file got
shifted to the wrong place in the output file. This doesn't happen if such
comments are present outside the declare section.

I know this is not a severe issue but certainly something that would be
nice correcting.

Thanks,

-- 
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

--000000000000a116e805ae2be580
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi All,<br><br>While working on some other issue, I notice=
d that the comments inside the declare section are not outputted correctly.=
 Have a look at the below example and its output.<br><br>void main(void)<br=
>{<br>exec sql begin declare section;<br>=C2=A0 =C2=A0 int v1 =3D 100;<br>/=
* First Layer */<br>#ifdef MACRO1<br>/* Second Layer */<br>#ifdef MACRO2<br=
>=C2=A0 =C2=A0int testVar =3D 2;<br>#endif<br>#endif<br>exec sql end declar=
e section;<br><br>=C2=A0 =C2=A0 return 1;<br>}<br><br><b><u>Output:</u></b>=
<br><br>void main(void)<br>{<br>/* exec sql begin declare section */<br><br=
>/* First Layer *//* Second Layer */<br>#line 4 &quot;test.pgc&quot;<br>=C2=
=A0int v1 =3D 100 ;<br><br>#ifdef MACRO1<br><br>#ifdef MACRO2<br><br>#line =
9 &quot;test.pgc&quot;<br>=C2=A0int testVar =3D 2 ;<br><br>#endif<br>=C2=A0=
#endif<br>/* exec sql end declare section */<br>#line 12 &quot;test.pgc&quo=
t;<br><br><br>=C2=A0 =C2=A0 return 1;<br>}<br><br>If you see the output, th=
e comments present inside the input file got shifted to the wrong place in =
the output file. This doesn&#39;t happen if such comments are present outsi=
de the declare section.<br><br>I know this is not a severe issue but certai=
nly something that would be nice correcting.<br><br>Thanks,<br><div><br></d=
iv><div>-- <br>With Regards,<br>Ashutosh Sharma<br>EnterpriseDB:<a href=3D"=
http://www.enterprisedb.com">http://www.enterprisedb.com</a><br></div></div=
>

--000000000000a116e805ae2be580--