public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ashutosh Sharma <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Cc: Michael Meskes <[email protected]>
Subject: Re: ecpg: issue related to preprocessor directives
Date: Mon, 3 Aug 2020 16:09:10 +0530
Message-ID: <CAE9k0PmE2JQKz8wp_aiixL=Cw=dgpH1mW-NQD6nOFhHqo+wyeg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAE9k0P=dQk9X0cU2tN49S7a9tv733-e1pVdpB1P-pWJ5PdTktg@mail.gmail.com>
	<[email protected]>
	<[email protected]>

Hi,

Thanks for the patch. I've spent quite some time reviewing it and the
changes look good to me.  It looks very neat and is also
crystal-clear.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

On Sat, Aug 1, 2020 at 8:05 PM Tom Lane <[email protected]> wrote:
>
> I wrote:
> > Looking at pgc.l, it seems that 'elif' is treated as though it were
> > 'endif' followed by 'ifdef', which of course completely loses the
> > expected property that a previous successful branch would keep the
> > elif branch from being expanded.
> > While this doesn't look terribly hard to fix, I'm a little disturbed
> > by the fact that the existing semantics seem to date back to 1999
> > (b57b0e044).  We're probably risking breaking existing app code if
> > we change it.  I think we *should* change it, of course, but I'm kind
> > of inclined not to back-patch.
>
> Here's a proposed patch, which also clarifies the documentation,
> which seemed a bit confused/misleading to me.
>
> As stated, I'm not sure it's wise to back-patch this aggressively
> ... but maybe it'd be okay to squeeze it into v13?
>
>                         regards, tom lane
>

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: ecpg: issue related to preprocessor directives
  In-Reply-To: <CAE9k0PmE2JQKz8wp_aiixL=Cw=dgpH1mW-NQD6nOFhHqo+wyeg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox