MIME-Version: 1.0
In-Reply-To: <1515668698.2860.92.camel@postgresql.org>
References: 
 <CAE9k0P=5jSNUw5NSO6xcbxTzfNo7Wrmc8TFFv2qVxKLAR-T6dQ@mail.gmail.com>
 <20180110122916.GA1160@feivel>
 <CAE9k0PnL0JCaKKWqFZY9x5Ar5+=ChUn-thf=CedAOV6LsdfDnQ@mail.gmail.com>
 <1515668698.2860.92.camel@postgresql.org>
From: Ashutosh Sharma <ashu.coek88@gmail.com>
Date: Thu, 11 Jan 2018 18:13:15 +0530
Message-ID: 
 <CAE9k0PneuT62kyqDbhEdeod3rd6PZiLJum=3S6Vo4f6-htSPUQ@mail.gmail.com>
Subject: Re: Compatibility modes supported in ECPG
To: Michael Meskes <meskes@postgresql.org>
Cc: pgsql-interfaces@lists.postgresql.org
Content-Type: multipart/mixed; boundary="089e082ce798ee1d5605627f7dfc"
Precedence: bulk

--089e082ce798ee1d5605627f7dfc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 11, 2018 at 4:34 PM, Michael Meskes <meskes@postgresql.org> wro=
te:
>> Thanks Michael. Shall i submit a patch for it. Also, what about
>
> Yes, please.
>

Thanks. Attached are the patches
'Allow_ecpg_to_throw_error_for_wrong_compat_modes_v1' and
'Allow_ecpg_to_throw_error_for_wrong_compat_modes_v2' that fixes the
reported issues.

>> making
>> the compatibility modes case insensitive. Currently, ecpg accepts
>> compatibility mode only in capital letters. In case if the INFORMIX
>> or
>> INFORMIX_SE is entered in small or mixed type letter, ecpg throws an
>> error. Shouldn't that be handled as well?
>
> Actually I don't mind either way. There is definitely an advantage of
> having it case insensitive, but then options are known to be case
> sensitive often enough.
>

I feel we should make them case insensitive. The reason being, other
embedded SQL programming languages for e.g. Pro*C accepts case
insensitive options. So, why can't we make our ecpg options case
insensitive as well. Thoughts?

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

> Michael
> --
> Michael Meskes
> Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
> Meskes at (Debian|Postgresql) dot Org
> Jabber: michael at xmpp dot meskes dot org
> VfL Borussia! For=C3=A7a Bar=C3=A7a! SF 49ers! Use Debian GNU/Linux, Post=
greSQL
>

--089e082ce798ee1d5605627f7dfc
Content-Type: text/x-patch; charset="US-ASCII";
	name="Allow_ecpg_to_throw_error_for_wrong_compat_modes_v1.patch"
Content-Disposition: attachment;
	filename="Allow_ecpg_to_throw_error_for_wrong_compat_modes_v1.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_jcahg84o0

ZGlmZiAtLWdpdCBhL3NyYy9pbnRlcmZhY2VzL2VjcGcvcHJlcHJvYy9lY3BnLmMgYi9zcmMvaW50
ZXJmYWNlcy9lY3BnL3ByZXByb2MvZWNwZy5jCmluZGV4IDhhMTQ1NzIuLmJhZGYwNDIgMTAwNjQ0
Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2VjcGcvcHJlcHJvYy9lY3BnLmMKKysrIGIvc3JjL2ludGVy
ZmFjZXMvZWNwZy9wcmVwcm9jL2VjcGcuYwpAQCAtMTk4LDcgKzE5OCw3IEBAIG1haW4oaW50IGFy
Z2MsIGNoYXIgKmNvbnN0IGFyZ3ZbXSkKIAkJCQlzeXN0ZW1faW5jbHVkZXMgPSB0cnVlOwogCQkJ
CWJyZWFrOwogCQkJY2FzZSAnQyc6Ci0JCQkJaWYgKHN0cm5jbXAob3B0YXJnLCAiSU5GT1JNSVgi
LCBzdHJsZW4oIklORk9STUlYIikpID09IDApCisJCQkJaWYgKHN0cmNtcChvcHRhcmcsICJJTkZP
Uk1JWCIpID09IDAgfHwgc3RyY21wKG9wdGFyZywgIklORk9STUlYX1NFIikgPT0gMCkKIAkJCQl7
CiAJCQkJCWNoYXIJCXBrZ2luY2x1ZGVfcGF0aFtNQVhQR1BBVEhdOwogCQkJCQljaGFyCQlpbmZv
cm1peF9wYXRoW01BWFBHUEFUSF07Cg==
--089e082ce798ee1d5605627f7dfc
Content-Type: text/x-patch; charset="US-ASCII";
	name="Allow_ecpg_to_throw_error_for_wrong_compat_modes_v2.patch"
Content-Disposition: attachment;
	filename="Allow_ecpg_to_throw_error_for_wrong_compat_modes_v2.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_jcahghin1

ZGlmZiAtLWdpdCBhL3NyYy9pbnRlcmZhY2VzL2VjcGcvcHJlcHJvYy9lY3BnLmMgYi9zcmMvaW50
ZXJmYWNlcy9lY3BnL3ByZXByb2MvZWNwZy5jCmluZGV4IDhhMTQ1NzIuLmNkNzcwYzggMTAwNjQ0
Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2VjcGcvcHJlcHJvYy9lY3BnLmMKKysrIGIvc3JjL2ludGVy
ZmFjZXMvZWNwZy9wcmVwcm9jL2VjcGcuYwpAQCAtMTk4LDEyICsxOTgsMTIgQEAgbWFpbihpbnQg
YXJnYywgY2hhciAqY29uc3QgYXJndltdKQogCQkJCXN5c3RlbV9pbmNsdWRlcyA9IHRydWU7CiAJ
CQkJYnJlYWs7CiAJCQljYXNlICdDJzoKLQkJCQlpZiAoc3RybmNtcChvcHRhcmcsICJJTkZPUk1J
WCIsIHN0cmxlbigiSU5GT1JNSVgiKSkgPT0gMCkKKwkJCQlpZiAocGdfc3RyY2FzZWNtcChvcHRh
cmcsICJJTkZPUk1JWCIpID09IDAgfHwgcGdfc3RyY2FzZWNtcChvcHRhcmcsICJJTkZPUk1JWF9T
RSIpID09IDApCiAJCQkJewogCQkJCQljaGFyCQlwa2dpbmNsdWRlX3BhdGhbTUFYUEdQQVRIXTsK
IAkJCQkJY2hhcgkJaW5mb3JtaXhfcGF0aFtNQVhQR1BBVEhdOwogCi0JCQkJCWNvbXBhdCA9IChz
dHJjbXAob3B0YXJnLCAiSU5GT1JNSVgiKSA9PSAwKSA/IEVDUEdfQ09NUEFUX0lORk9STUlYIDog
RUNQR19DT01QQVRfSU5GT1JNSVhfU0U7CisJCQkJCWNvbXBhdCA9IChwZ19zdHJjYXNlY21wKG9w
dGFyZywgIklORk9STUlYIikgPT0gMCkgPyBFQ1BHX0NPTVBBVF9JTkZPUk1JWCA6IEVDUEdfQ09N
UEFUX0lORk9STUlYX1NFOwogCQkJCQlnZXRfcGtnaW5jbHVkZV9wYXRoKG15X2V4ZWNfcGF0aCwg
cGtnaW5jbHVkZV9wYXRoKTsKIAkJCQkJc25wcmludGYoaW5mb3JtaXhfcGF0aCwgTUFYUEdQQVRI
LCAiJXMvaW5mb3JtaXgvZXNxbCIsIHBrZ2luY2x1ZGVfcGF0aCk7CiAJCQkJCWFkZF9pbmNsdWRl
X3BhdGgoaW5mb3JtaXhfcGF0aCk7Cg==
--089e082ce798ee1d5605627f7dfc--