Received: from localhost (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id 15F5C4762F5 for ; Thu, 16 Jan 2003 05:05:51 -0500 (EST) Received: from news.hub.org (news.hub.org [64.49.215.80]) by postgresql.org (Postfix) with ESMTP id 6C1C847624A for ; Thu, 16 Jan 2003 05:05:49 -0500 (EST) Received: by news.hub.org (Postfix, from userid 8) id 5865F43A9A4; Thu, 16 Jan 2003 05:05:49 -0500 (EST) From: g.hintermayer@inode.at (Gerhard Hintermayer) X-Newsgroups: comp.databases.postgresql.interfaces Subject: Re: still memory leaks with libpgtcl Date: 16 Jan 2003 01:34:06 -0800 Organization: http://groups.google.com/ Lines: 32 Message-ID: References: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Complaints-To: groups-abuse@google.com To: pgsql-interfaces@postgresql.org X-Virus-Scanned: by AMaViS new-20020517 X-Archive-Number: 200301/72 X-Sequence-Number: 3572 ljb wrote in message > [...] > (This is for PostgreSQL-7.3.1) > > --- src/interfaces/libpgtcl/pgtclId.c.bak 2002-10-17 10:53:32.000000000 -0400 > +++ src/interfaces/libpgtcl/pgtclId.c 2003-01-07 21:51:53.000000000 -0500 > @@ -300,12 +300,10 @@ > * small) amount of memory taken for the channel state representation. > * Note we are not leaking a socket, since libpq closed that already. > */ > -#ifdef NOT_USED > #if TCL_MAJOR_VERSION >= 8 > - if (connid->notifier_channel != NULL) > + if (connid->notifier_channel != NULL && interp != NULL) > Tcl_UnregisterChannel(NULL, connid->notifier_channel); > #endif > -#endif > > /* > * We must use Tcl_EventuallyFree because we don't want the connid Your patch does indeed fix the memory leakage but seems to introduce another problem. Every once in a while I do get segfaults, when I enter the event loop after pg_disconnect-ing (well, it looks like that to me). I have to say, that this is the only script, where the error occurs. All others (~500) work with no problem at all. I was trying to reproduce that in a short script, but - no way. I am not even sure, if this is postgreSQL related. I did build a static wish with --enable-symbols=all and --enable-memory to track the error down. Hope I'll see more then. Gerhard