X-Original-To: pgsql-interfaces-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id BD93F53350 for ; Fri, 8 Apr 2005 21:24:18 +0100 (BST) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 31973-06 for ; Fri, 8 Apr 2005 20:24:16 +0000 (GMT) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.206]) by svr1.postgresql.org (Postfix) with ESMTP id 4108953349 for ; Fri, 8 Apr 2005 21:24:15 +0100 (BST) Received: by wproxy.gmail.com with SMTP id 69so1157827wri for ; Fri, 08 Apr 2005 13:24:17 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=pTyV4sPcKu8t6gAn9WPOop7Y+wg4nJrn6L9HKHnvUXRGTs5s9UZkZ+oeqBXvZq9IfxX+v1+lXymHcWPAyOOJv52r9Y2JYJGrqO+epCYQ/12cqmeObZVii1Ask1U90bu2w9E7H3nhFAxFa5pj0rLeP/QXvdQlMizpvg74K+C0+xw= Received: by 10.54.34.64 with SMTP id h64mr2072771wrh; Fri, 08 Apr 2005 13:24:17 -0700 (PDT) Received: by 10.54.45.39 with HTTP; Fri, 8 Apr 2005 13:24:17 -0700 (PDT) Message-ID: Date: Fri, 8 Apr 2005 16:24:17 -0400 From: Vlad Reply-To: Vlad To: Brandon Metcalf Subject: Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg Cc: Tom Lane , dbdpg-general@gborg.postgresql.org, pgsql-interfaces@postgresql.org In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit References: <16221.1112987509@sss.pgh.pa.us> X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.272 tagged_above=0 required=5 tests=AWL, DNS_FROM_RFC_ABUSE, RCVD_BY_IP X-Spam-Level: X-Archive-Number: 200504/36 X-Sequence-Number: 5452 Brandon, try this patch instead. diff -ru DBD-Pg-1.41/dbdimp.c DBD-Pg-1.41-patched/dbdimp.c --- DBD-Pg-1.41/dbdimp.c Fri Apr 8 16:06:12 2005 +++ DBD-Pg-1.41-patched/dbdimp.c Fri Apr 8 15:46:50 2005 @@ -1415,7 +1415,7 @@ } else if (NULL == currph->bind_type) { /* "sticky" data type */ /* This is the default type, but we will honor defaultval if we can */ - currph->bind_type = pg_type_data(VARCHAROID); + currph->bind_type = pg_type_data(UNKNOWNOID); if (!currph->bind_type) croak("Default type is bad!!!!???"); } diff -ru DBD-Pg-1.41/types.c DBD-Pg-1.41-patched/types.c --- DBD-Pg-1.41/types.c Fri Apr 8 16:06:23 2005 +++ DBD-Pg-1.41-patched/types.c Fri Apr 8 15:46:37 2005 @@ -55,7 +55,7 @@ {ABSTIMEOID, "abstime", DBDPG_TRUE, null_quote, null_dequote, {0}}, {RELTIMEOID, "reltime", DBDPG_TRUE, null_quote, null_dequote, {0}}, {TINTERVALOID, "tinterval", DBDPG_TRUE, null_quote, null_dequote, {0}}, - {UNKNOWNOID, "unknown", DBDPG_FALSE, null_quote, null_dequote, {0}}, + {UNKNOWNOID, "unknown", DBDPG_FALSE, quote_varchar, null_dequote, {0}}, {CIRCLEOID, "circle", DBDPG_FALSE, null_quote, null_dequote, {0}}, {CASHOID, "money", DBDPG_TRUE, null_quote, null_dequote, {0}}, {MACADDROID, "MAC address", DBDPG_TRUE, quote_varchar,dequote_varchar, {0}}, On Apr 8, 2005 4:14 PM, Brandon Metcalf wrote: > m == marchenko@gmail.com writes: > > m> --- dbdimp.c.bak Wed Apr 6 16:40:20 2005 > m> +++ dbdimp.c Fri Apr 8 15:21:29 2005 > m> @@ -1415,7 +1415,7 @@ > m> } > m> else if (NULL == currph->bind_type) { /* "sticky" data type */ > m> /* This is the default type, but we will honor > m> defaultval if we can */ > m> - currph->bind_type = pg_type_data(VARCHAROID); > m> + currph->bind_type = pg_type_data(UNKNOWNOID); > m> if (!currph->bind_type) > m> croak("Default type is bad!!!!???"); > m> } > > Using this patch results in error messages like: > > DBD::Pg::st execute failed: ERROR: syntax error at or near "15" at character 158 > > Not sure why yet. > > -- > Brandon > -- Vlad