X-Original-To: pgsql-interfaces-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id ED12B5358D for ; Fri, 8 Apr 2005 21:56:12 +0100 (BST) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 42261-04 for ; Fri, 8 Apr 2005 20:56:12 +0000 (GMT) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.198]) by svr1.postgresql.org (Postfix) with ESMTP id CF788535AF for ; Fri, 8 Apr 2005 21:56:11 +0100 (BST) Received: by wproxy.gmail.com with SMTP id 68so2022670wra for ; Fri, 08 Apr 2005 13:56:13 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=JxgkCpzoLvcxfDkh9UPnNbhec0U4vkMO8qWdLZCM41eSRameU88tsGV5wN50d4POLjEySWWaDY0WiU8ZualNn72PdjC/4lLIeF4tbUUYptMr7fdh++AfPY1z+p7bPdh2r0bcVlqyisuXDKOfK1WWznUQ7/5EMFBVFIBAWTIfMWY= Received: by 10.54.14.71 with SMTP id 71mr56747wrn; Fri, 08 Apr 2005 13:56:13 -0700 (PDT) Received: by 10.54.45.39 with HTTP; Fri, 8 Apr 2005 13:56:13 -0700 (PDT) Message-ID: Date: Fri, 8 Apr 2005 16:56:13 -0400 From: Vlad Reply-To: Vlad To: Tom Lane Subject: Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg Cc: Brandon Metcalf , dbdpg-general@gborg.postgresql.org, pgsql-interfaces@postgresql.org In-Reply-To: <16762.1112992897@sss.pgh.pa.us> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit References: <16221.1112987509@sss.pgh.pa.us> <16762.1112992897@sss.pgh.pa.us> X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.274 tagged_above=0 required=5 tests=AWL, DNS_FROM_RFC_ABUSE, RCVD_BY_IP X-Spam-Level: X-Archive-Number: 200504/39 X-Sequence-Number: 5455 Tom, > > diff -ru DBD-Pg-1.41/types.c DBD-Pg-1.41-patched/types.c > > --- DBD-Pg-1.41/types.c Fri Apr 8 16:06:23 2005 > > +++ DBD-Pg-1.41-patched/types.c Fri Apr 8 15:46:37 2005 > > @@ -55,7 +55,7 @@ > > {ABSTIMEOID, "abstime", DBDPG_TRUE, null_quote, null_dequote, {0}}, > > {RELTIMEOID, "reltime", DBDPG_TRUE, null_quote, null_dequote, {0}}, > > {TINTERVALOID, "tinterval", DBDPG_TRUE, null_quote, null_dequote, {0}}, > > - {UNKNOWNOID, "unknown", DBDPG_FALSE, null_quote, null_dequote, {0}}, > > + {UNKNOWNOID, "unknown", DBDPG_FALSE, quote_varchar, null_dequote, {0}}, > > {CIRCLEOID, "circle", DBDPG_FALSE, null_quote, null_dequote, {0}}, > > {CASHOID, "money", DBDPG_TRUE, null_quote, null_dequote, {0}}, > > {MACADDROID, "MAC address", DBDPG_TRUE, > > quote_varchar,dequote_varchar, {0}}, > > Hmm ... if those columns mean what it looks like they mean, quite a few > of the other entries seem wrong too. All of the types visible in that > fragment ought to be quoted when used as SQL literals. > > Also, if the MACADDROID entry is any precedent, shouldn't you be > changing the dequote field too? I'm not with the development team of DBD::Pg to make those changes, but I'm confident that it will be much appreciated by them (and myself and other users of DBD::Pg for sure) if you could review its code in regards to the type conversion issue and give your suggestions. http://search.cpan.org/~dbdpg/DBD-Pg-1.41/ -- Vlad