X-Original-To: pgsql-interfaces-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 1CDEB5321C for ; Sat, 9 Apr 2005 00:38:19 +0100 (BST) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 77182-03 for ; Fri, 8 Apr 2005 23:38:09 +0000 (GMT) Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.195]) by svr1.postgresql.org (Postfix) with ESMTP id 20E075296B for ; Sat, 9 Apr 2005 00:38:08 +0100 (BST) Received: by wproxy.gmail.com with SMTP id 68so2078116wra for ; Fri, 08 Apr 2005 16:38:12 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=mNZdaiyy1i9SDo1eKOZGis44RutMe8ZrfHX43a8aioZAJR+Mp3dAQw1/vNSQAU9sDPhS5U/rwiTBLloYrVuiMy1Xe3OYEI3+HbbGd2tzdmz81lNsIoHUSrhSfQfzjDUPaYGUuINvfeOyjKu3LdKt76MpTItawcP37C7f6OOMKcA= Received: by 10.54.53.38 with SMTP id b38mr159886wra; Fri, 08 Apr 2005 16:38:11 -0700 (PDT) Received: by 10.54.45.39 with HTTP; Fri, 8 Apr 2005 16:38:11 -0700 (PDT) Message-ID: Date: Fri, 8 Apr 2005 19:38:11 -0400 From: Vlad Reply-To: Vlad To: Greg Sabino Mullane Subject: Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg Cc: dbdpg-general@gborg.postgresql.org, pgsql-interfaces@postgresql.org In-Reply-To: <7faf5fa48d5bef0dbd507740522747bf@biglumber.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit References: <7faf5fa48d5bef0dbd507740522747bf@biglumber.com> X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.275 tagged_above=0 required=5 tests=AWL, DNS_FROM_RFC_ABUSE, RCVD_BY_IP X-Spam-Level: X-Archive-Number: 200504/41 X-Sequence-Number: 5457 Greg, just re-run my tests with freshly compiled PostgreSQL 8.0.2 (congrats on release, btw) DBD:Pg 1.32 - fast DBD:Pg 1.40 - slooow and buggy, won't work w/o patching DBD:Pg 1.41 - fast DBD:Pg 1.41 patched - fast the patch I've applied in last test: diff -ru DBD-Pg-1.41/dbdimp.c DBD-Pg-1.41-patched/dbdimp.c --- DBD-Pg-1.41/dbdimp.c Fri Apr 8 16:06:12 2005 +++ DBD-Pg-1.41-patched/dbdimp.c Fri Apr 8 15:46:50 2005 @@ -1415,7 +1415,7 @@ } else if (NULL == currph->bind_type) { /* "sticky" data type */ /* This is the default type, but we will honor defaultval if we can */ - currph->bind_type = pg_type_data(VARCHAROID); + currph->bind_type = pg_type_data(UNKNOWNOID); if (!currph->bind_type) croak("Default type is bad!!!!???"); } diff -ru DBD-Pg-1.41/types.c DBD-Pg-1.41-patched/types.c --- DBD-Pg-1.41/types.c Fri Apr 8 16:06:23 2005 +++ DBD-Pg-1.41-patched/types.c Fri Apr 8 17:23:48 2005 @@ -55,7 +55,7 @@ {ABSTIMEOID, "abstime", DBDPG_TRUE, null_quote, null_dequote, {0}}, {RELTIMEOID, "reltime", DBDPG_TRUE, null_quote, null_dequote, {0}}, {TINTERVALOID, "tinterval", DBDPG_TRUE, null_quote, null_dequote, {0}}, - {UNKNOWNOID, "unknown", DBDPG_FALSE, null_quote, null_dequote, {0}}, + {UNKNOWNOID, "unknown", DBDPG_FALSE, quote_varchar, dequote_varchar, {0}}, {CIRCLEOID, "circle", DBDPG_FALSE, null_quote, null_dequote, {0}}, {CASHOID, "money", DBDPG_TRUE, null_quote, null_dequote, {0}}, {MACADDROID, "MAC address", DBDPG_TRUE, quote_varchar,dequote_varchar, {0}}, On Apr 8, 2005 6:17 PM, Greg Sabino Mullane wrote: > Let's slow down and back up a bit. First, what version of > PostgreSQL are you using to compile DBD::Pg, and what version > are you connecting to? Many of the things being discussed > have already been solved if you are running a modern version > of PG (e.g. 7.4 or greater). -- Vlad