Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rLIzY-007EoC-8V for pgsql-jdbc-commits@arkaria.postgresql.org; Thu, 04 Jan 2024 08:22:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rLIzU-00BGgi-DO for pgsql-jdbc-commits@arkaria.postgresql.org; Thu, 04 Jan 2024 08:22:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rLIzU-00BGgZ-5c for pgsql-jdbc-commits@lists.postgresql.org; Thu, 04 Jan 2024 08:22:12 +0000 Received: from out-27.smtp.github.com ([192.30.252.210]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rLIzR-00FTCd-4f for pgsql-jdbc-commits@lists.postgresql.org; Thu, 04 Jan 2024 08:22:11 +0000 Received: from github.com (hubbernetes-node-e4d2fc8.ash1-iad.github.net [10.56.144.31]) by smtp.github.com (Postfix) with ESMTPA id 12F346010E4 for ; Thu, 4 Jan 2024 00:22:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2023; t=1704356527; bh=K3dUHv3OsEq1DED92W8poT9w5gr+6GGO47ql7i/nlFA=; h=Date:From:To:Subject:From; b=ZEYSwumu2iQ6Qo7DYSpGuPPY7BRmJPowNgPq+fW9ChEVK/Y8P2ZOOaBWnmyKubmgX m3TIwx9ez3KaDSdQdJvTq7Z/Q8/30V3zM12QzewFQpqgTzW9lh/EEBNgMh47OgHwtj IlM+H7ukaPjVIM6MIq82Ql4MXA6TqRQAFGBFSibU= Date: Thu, 04 Jan 2024 00:22:07 -0800 From: Vladimir Sitnikov To: pgsql-jdbc-commits@lists.postgresql.org Message-ID: Subject: [pgjdbc/pgjdbc] 53799e: refactor: document that encodePassword will zero o... Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Approved: 58GruLoMopuc X-GitHub-Recipient-Address: pgsql-jdbc-commits@lists.postgresql.org X-Auto-Response-Suppress: All List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Branch: refs/heads/master Home: https://github.com/pgjdbc/pgjdbc Commit: 53799e4fd733e8a7e288025388b284c15b523a09 https://github.com/pgjdbc/pgjdbc/commit/53799e4fd733e8a7e288025388b284c15b523a09 Author: Vladimir Sitnikov Date: 2024-01-03 (Wed, 03 Jan 2024) Changed paths: M pgjdbc/src/main/java/org/postgresql/PGConnection.java M pgjdbc/src/main/java/org/postgresql/util/PasswordUtil.java M pgjdbc/src/test/java/org/postgresql/test/util/PasswordUtilTest.java Log Message: ----------- refactor: document that encodePassword will zero out the password array, and remove driver's default encodePassword Having unknown driver's default password encoding does not help clients as they will not be sure if the database supports the encoding or not. They should prefer org.postgresql.PGConnection#alterUserPassword as it would select database-default encoding which might improve over time.