Received: from localhost (postgresql.org [64.49.215.8])
	by postgresql.org (Postfix) with ESMTP id A9F0A475B8F
	for <pgsql-jdbc@postgresql.org>; Mon, 20 Jan 2003 01:51:53 -0500 (EST)
Received: from ebola.biohz.net (adsl-66-127-84-214.dsl.sntc01.pacbell.net
	[66.127.84.214])
	by postgresql.org (Postfix) with ESMTP id AEEC0475D22
	for <pgsql-jdbc@postgresql.org>; Mon, 20 Jan 2003 01:51:52 -0500 (EST)
Received: from flu (localhost [127.0.0.1])
	by ebola.biohz.net (Postfix) with SMTP id 461EF11535B
	for <pgsql-jdbc@postgresql.org>; Sun, 19 Jan 2003 22:51:52 -0800 (PST)
Message-ID: <000a01c2c050$69c79780$011211ac@biohz.net>
From: "Renaud Waldura" <renaud@waldura.com>
To: <pgsql-jdbc@postgresql.org>
Subject: Requiring Ant 1.5 for build breaks JDK 1.1 compatibility
Date: Sun, 19 Jan 2003 22:51:52 -0800
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_NextPart_000_0007_01C2C00D.5B68D520"
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4807.1700
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700
X-Virus-Scanned: by AMaViS new-20020517
X-Archive-Number: 200301/261
X-Sequence-Number: 6111

This is a multi-part message in MIME format.

------=_NextPart_000_0007_01C2C00D.5B68D520
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit

Dear PostgreSQL JDBC driver developers,

I was pleased to find that your JDBC driver for PostgreSQL only requires JDK
1.1 for minimal functionality. Congratulations and thank you for doing so.

Unfortunately building the driver requires Ant 1.5, which itself requires
JDK 1.2. This dependency breaks the ability to compile and use the driver on
a JDK 1.1 platform such as mine.

I tried to build the driver with Ant 1.4, which only requires JDK 1.1, and
it worked in fact just fine, apart from some minor problems for which I
include a patch. It appears to me the Ant 1.5 (thus JDK 1.2) dependency is a
rather weak one, and only present for convenience reasons.

As this breaks JDK 1.1 compatibility, which the driver itself supports, I
wish you would reconsider, and maybe altogether drop, this dependency.
Thanks!

The included patch allowed me to cleanly build and compile version 7.3.1 of
the JDBC driver on FreeBSD 4.2.

--Renaud

------=_NextPart_000_0007_01C2C00D.5B68D520
Content-Type: application/octet-stream;
	name="pgsql-patch.txt"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="pgsql-patch.txt"

--- configure.in_orig	Sun Jan 19 22:03:06 2003
+++ configure.in	Sun Jan 19 22:03:27 2003
@@ -385,7 +385,7 @@
   AC_MSG_ERROR([Ant is required to build Java components
 If you have Ant already installed, see config.log for details on the failu=
re.])
 fi
-if "$ANT" -version | sed q | egrep -v ' 1\.[[5-9]]| [[2-9]]\.' >/dev/null =
; then
+if "$ANT" -version | sed q | egrep -v ' 1\.[[4-9]]| [[2-9]]\.' >/dev/null =
; then
   AC_MSG_ERROR([Ant version >=3D 1.5 is required to build Java components])
 fi],
 [AC_MSG_RESULT(no)])
--- src/interfaces/jdbc/build.xml_orig	Sun Jan 19 22:23:46 2003
+++ src/interfaces/jdbc/build.xml	Sun Jan 19 22:30:30 2003
@@ -48,21 +48,21 @@
     <available property=3D"junit" classname=3D"junit.framework.Test" />
     <condition property=3D"jdbc2tests">
       <and>
-        <isset property=3D"jdbc2"/>
-        <isset property=3D"junit"/>
+        <equals arg1=3D"${jdbc2}" arg2=3D"true" />
+        <equals arg1=3D"${junit}" arg2=3D"true" />
       </and>
     </condition>
     <condition property=3D"jdbc2optionaltests">
       <and>
-        <isset property=3D"jdbc2"/>
-        <isset property=3D"datasource"/>
-        <isset property=3D"junit"/>
+        <equals arg1=3D"${jdbc2}" arg2=3D"true" />
+        <equals arg1=3D"${datasource}" arg2=3D"true" />
+        <equals arg1=3D"${junit}" arg2=3D"true" />
       </and>
     </condition>
     <condition property=3D"jdbc3tests">
       <and>
-        <isset property=3D"jdbc3"/>
-        <isset property=3D"junit"/>
+        <equals arg1=3D"${jdbc3}" arg2=3D"true" />
+        <equals arg1=3D"${junit}" arg2=3D"true" />
       </and>
     </condition>
   </target>
@@ -156,8 +156,8 @@
     <filter token=3D"JDBCCONNECTCLASS" value=3D"${connectclass}" />
     <filter token=3D"DEF_PGPORT" value=3D"${def_pgport}" />
=20
-     <fail unless=3D"major" message=3D"'major' undefined. Please follow th=
e directions in README."/>
-     <fail unless=3D"minor" message=3D"'minor' undefined. Please follow th=
e directions in README."/>
+     <!-- fail unless=3D"major" message=3D"'major' undefined. Please follo=
w the directions in README."/> -->
+     <!-- fail unless=3D"minor" message=3D"'minor' undefined. Please follo=
w the directions in README."/> -->
=20=20
     <!-- Put a check for the current version here -->
=20

------=_NextPart_000_0007_01C2C00D.5B68D520--