public inbox for [email protected]  

help / color / mirror / Atom feed

From: Achilleas Mantzios - cloud <[email protected]>
To: Dave Cramer <[email protected]>
Cc: Vladimir Sitnikov <[email protected]>
Cc: [email protected]
Subject: Re: Regarding useObjects
Date: Wed, 27 Sep 2023 13:00:09 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CADK3HH+9O5=Y4RSCxCCBaewGPWBQ3zzTjqD0DoZJuD9wCc73uQ@mail.gmail.com>
References: <[email protected]>
	<CAB=Je-HiDQ_pSp5PTfuRUEt6WA5bNNgYWS_8Q6wUHO1qg4=RFQ@mail.gmail.com>
	<[email protected]>
	<CAB=Je-G=X8UbhjB5HF8d9WS5eZdVUgqopvsocD5_0WpxOHcAyw@mail.gmail.com>
	<[email protected]>
	<CADK3HH+9O5=Y4RSCxCCBaewGPWBQ3zzTjqD0DoZJuD9wCc73uQ@mail.gmail.com>


On 9/27/23 12:44, Dave Cramer wrote:
>
>
> On Wed, 27 Sept 2023 at 05:00, Achilleas Mantzios - cloud 
> <[email protected]> wrote:
>
>     Good Day Vladimir
>
>     On 9/27/23 09:03, Vladimir Sitnikov wrote:
>     >> so there was the option to change this to false and recompile
>     > We try doing our best to keep backward compatibility both
>     > compilation-wise and behaviour-wise.
>     > However, we treat "private fields and methods" as private, and we do
>     > not expect people would depend on them.
>     > If you have to modify sources or depend on private APIs I would
>     > suggest raising an issue or PR so it could be incorporated
>     > into the driver itself.
>     >
>     > Would you please provide a test case of what you are doing with
>     PgArray?
>     > What is exactly the sequence of JDBC calls, the actual and the
>     > expected outcomes in your case?
>
>     E.g. for the case of floats, we have to change all:
>
>     java.sql.Array arr = rs.getArray(1);
>
>     Object objarr = arr.getArray();
>
>     float flarr[] = (float[]) objarr;
>
>     to
>
>     java.sql.Array arr = rs.getArray(1);
>
>     Object objarr = arr.getArray();
>
>     Float flarr[] = (Float[]) objarr;
>
>
>
> So the problem with using float instead of Float is that it is 
> impossible to have a null float and arrays can have nulls.

Thanks Dave, we wrote much of the code before 2008, and we had to 
implement our own version of nulls in arrays of primitives. So this code 
was stuck everywhere. Plus we got like 120+ remote sites (slaves) ( 
which run ... even older code) so we must fully support them as well. 
Its only about 200 source files in the central system's repo, so we will 
have to do it sooner or later.

The hard part would be migrating from pgsql 10 to 16.

>
> Dave
>
>
>     >
>     > The mentioned "useObjects" has been removed in
>     > https://github.com/pgjdbc/pgjdbc/pull/1194 (Refactor decoding
>     arrays)
>     >
>     > Vladimir
>
>

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Regarding useObjects
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox