MIME-Version: 1.0
References: 
 <CAKU4AWog5YvO7wOBQ7nyGhV5JAm2s9sLoANGJMuG6BjJbDPAKA@mail.gmail.com>
In-Reply-To: 
 <CAKU4AWog5YvO7wOBQ7nyGhV5JAm2s9sLoANGJMuG6BjJbDPAKA@mail.gmail.com>
From: Andy Fan <zhihui.fan1213@gmail.com>
Date: Sun, 26 Mar 2023 16:16:37 +0800
Message-ID: 
 <CAKU4AWq-gwRS5FtVUqv-+vdRqi4HvF-=2gxZSFv-rOhnfWS-WA@mail.gmail.com>
Subject: Re: Duplicate Proxy.newProxyInstance calls during
 PGXAConnection.getConnection?
To: pgsql-jdbc@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000075341e05f7c93fbc"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKU4AWq-gwRS5FtVUqv-%2BvdRqi4HvF-%3D2gxZSFv-rOhnfWS-WA%40mail.gmail.com>
Precedence: bulk

--00000000000075341e05f7c93fbc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Please forgive me, I was totally wrong here.  Sorry for the noise.

On Sun, Mar 26, 2023 at 3:16=E2=80=AFPM Andy Fan <zhihui.fan1213@gmail.com>=
 wrote:

> In the PGXAConnection.GetConnection() [1], we can see the below code:
>
>   @Override
>   public Connection getConnection() throws SQLException {
>
>     // *the first time ConnectionHandler has been created.*
>     Connection conn =3D super.getConnection();
>
>     // When we're outside an XA transaction, autocommit
>     // is supposed to be true, per usual JDBC convention.
>     // When an XA transaction is in progress, it should be
>     // false.
>     if (state =3D=3D State.IDLE) {
>       conn.setAutoCommit(true);
>     }
>
>     /*
>      * Wrap the connection in a proxy to forbid application from fiddling=
 with transaction state
>      * directly during an XA transaction
>      */
>
>     // *ConnectionHandler is created again here. *
>     ConnectionHandler handler =3D new ConnectionHandler(conn);
>     return (Connection) Proxy.newProxyInstance(getClass().getClassLoader(=
),
>         new Class[]{Connection.class, PGConnection.class}, handler);
>   }
>
>
> However I think the proxy has already been created at the first line:
> super.getConnection(),
> and then it is created later.  Is it a duplication?
>
> [1]
> https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/pos=
tgresql/xa/PGXAConnection.java#L86
>
>
> --
> Best Regards
> Andy Fan
>


--=20
Best Regards
Andy Fan

--00000000000075341e05f7c93fbc
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Please forgive me, I was totally wrong here.=C2=A0 Sorry f=
or=C2=A0the noise.=C2=A0</div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Sun, Mar 26, 2023 at 3:16=E2=80=AFPM Andy Fan &l=
t;<a href=3D"mailto:zhihui.fan1213@gmail.com">zhihui.fan1213@gmail.com</a>&=
gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0=
px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div =
dir=3D"ltr">In the PGXAConnection.GetConnection() [1], we can see the below=
 code:<div><br></div><div><table style=3D"border-spacing:0px;border-collaps=
e:collapse;color:rgb(36,41,47);font-family:-apple-system,&quot;system-ui&qu=
ot;,&quot;Segoe UI&quot;,&quot;Noto Sans&quot;,Helvetica,Arial,sans-serif,&=
quot;Apple Color Emoji&quot;,&quot;Segoe UI Emoji&quot;;font-size:14px"><tb=
ody style=3D"box-sizing:border-box"><tr style=3D"box-sizing:border-box;back=
ground-color:transparent"><td id=3D"m_-2740031645688593835gmail-LC86" style=
=3D"box-sizing:border-box;padding:0px 10px;line-height:20px;vertical-align:=
top;overflow:visible;font-family:ui-monospace,SFMono-Regular,&quot;SF Mono&=
quot;,Menlo,Consolas,&quot;Liberation Mono&quot;,monospace;font-size:12px;w=
hite-space:pre-wrap"><pre style=3D"color:rgb(0,0,0);white-space:pre-wrap"> =
 @Override
  public Connection getConnection() throws SQLException {</pre><pre style=
=3D"color:rgb(0,0,0);white-space:pre-wrap">    // <b>the first time Connect=
ionHandler has been created.</b>
    Connection conn =3D super.getConnection();  =20

    // When we&#39;re outside an XA transaction, autocommit
    // is supposed to be true, per usual JDBC convention.
    // When an XA transaction is in progress, it should be
    // false.
    if (state =3D=3D State.IDLE) {
      conn.setAutoCommit(true);
    }

    /*
     * Wrap the connection in a proxy to forbid application from fiddling w=
ith transaction state
     * directly during an XA transaction
     */</pre><pre style=3D"color:rgb(0,0,0);white-space:pre-wrap">    // <b=
 style=3D"font-family:ui-monospace,SFMono-Regular,&quot;SF Mono&quot;,Menlo=
,Consolas,&quot;Liberation Mono&quot;,monospace;background-color:transparen=
t">ConnectionHandler is created again here. </b>
    ConnectionHandler handler =3D new ConnectionHandler(conn);
    return (Connection) Proxy.newProxyInstance(getClass().getClassLoader(),
        new Class[]{Connection.class, PGConnection.class}, handler);
  }
</pre><br></td></tr></tbody></table></div><div>However I think the proxy ha=
s already been created at the first line: super.getConnection(),=C2=A0</div=
><div>and then it is created later.=C2=A0 Is it a duplication?=C2=A0</div><=
div><br></div><div>[1]=C2=A0<a href=3D"https://github.com/pgjdbc/pgjdbc/blo=
b/master/pgjdbc/src/main/java/org/postgresql/xa/PGXAConnection.java#L86" ta=
rget=3D"_blank">https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/mai=
n/java/org/postgresql/xa/PGXAConnection.java#L86</a>=C2=A0<br clear=3D"all"=
><div><br></div><span>-- </span><br><div dir=3D"ltr"><div dir=3D"ltr">Best =
Regards<div>Andy Fan</div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div><span class=3D"gmail_si=
gnature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><d=
iv dir=3D"ltr">Best Regards<div>Andy Fan</div></div></div>

--00000000000075341e05f7c93fbc--