Content-Type: multipart/alternative;
 boundary="------------oSX3UTdJ6ZCL8c0LF62gHAQP"
Message-ID: <db49d8e8-508f-48ef-ace8-95ae55e986e9@yahoo.com>
Date: Wed, 29 Nov 2023 17:06:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Driver hangs in
 connect->MakeSSL.convert->SSLSocketImpl.startHandshake
Content-Language: en-US
To: pgsql-jdbc@lists.postgresql.org
References: <2c2e0f5d-4fe2-472f-a213-5cf58ec993c5.ref@yahoo.com>
 <2c2e0f5d-4fe2-472f-a213-5cf58ec993c5@yahoo.com>
 <CADK3HHKHZMi6FBJD6bp+_9W_HrFkGghevYeccrjv-+=+buGkMA@mail.gmail.com>
 <CADK3HHJDQjz1a8EbE7LE1Cv0S57zR7nZ02=9hLqKmqF7VOq2ww@mail.gmail.com>
From: Martin Lichtin <lichtin@yahoo.com>
In-Reply-To: 
 <CADK3HHJDQjz1a8EbE7LE1Cv0S57zR7nZ02=9hLqKmqF7VOq2ww@mail.gmail.com>
Content-Length: 10266
Archived-At: 
 <https://www.postgresql.org/message-id/db49d8e8-508f-48ef-ace8-95ae55e986e9%40yahoo.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------oSX3UTdJ6ZCL8c0LF62gHAQP
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 28/11/2023 21:28, Dave Cramer wrote:
> On Tue, 28 Nov 2023 at 09:07, Dave Cramer <davecramer@postgres.rocks> 
> wrote:
>
>     Hi Martin,
>
>     Thanks for the report. I'll have a look.
>     Dave Cramer
>
>     On Tue, 28 Nov 2023 at 08:27, Martin Lichtin <lichtin@yahoo.com>
>     wrote:
>
>         Hi
>
>         I'm seeing this thread hanging in the "getConnection" method,
>         with no timeout in sight.
>         However, the PGXADataSource is configured with a
>         "connectTimeout" of 10 seconds.
>
>            java.lang.Thread.State: RUNNABLE
>             at java.net.SocketInputStream.socketRead0(Native Method)
>             at
>         java.net.SocketInputStream.socketRead(SocketInputStream.java:116)
>             at java.net.SocketInputStream.read(SocketInputStream.java:171)
>             at java.net.SocketInputStream.read(SocketInputStream.java:141)
>             at
>         sun.security.ssl.SSLSocketInputRecord.read(SSLSocketInputRecord.java:464)
>             at
>         sun.security.ssl.SSLSocketInputRecord.decode(SSLSocketInputRecord.java:165)
>             at sun.security.ssl.SSLTransport.decode(SSLTransport.java:109)
>             at
>         sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1392)
>             at
>         sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1300)
>             at
>         sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:435)
>             at org.postgresql.ssl.MakeSSL.convert(MakeSSL.java:41)
>         ...
>             at
>         java.sql.DriverManager.getConnection(DriverManager.java:247)
>             at
>         org.postgresql.ds.common.BaseDataSource.getConnection(BaseDataSource.java:103)
>             at
>         org.postgresql.xa.PGXADataSource.getXAConnection(PGXADataSource.java:49)
>             at
>         org.postgresql.xa.PGXADataSource.getXAConnection(PGXADataSource.java:35)
>
>         Any reason this timeout is not being applied here?
>
>         The version in use here is 42.3.6
>
>
> This Make sure to pass any network timeouts to the new SSL connection. 
> by davecramer · Pull Request #3040 · pgjdbc/pgjdbc (github.com) 
> <https://github.com/pgjdbc/pgjdbc/pull/3040> should fix the problem, 
> can you check ?

Thanks! I'll try. Was hoping for a SNAPSHOT version with this change in, 
but looks like these are no longer produced(?), although mentioned here 
https://jdbc.postgresql.org/download/ Anyways, it will be quite hard to 
reproduce this socket-read hang situation, so not sure I'll be able to 
test the change :)

Some more observations (obv from a newcomer to this space..):

As mentioned I'm setting "connectTimeout". Is this value somehow 
trickling down, and ending up at what's called "networkTimeout" in the code?
I'm asking as networkTimeout is not a connection parameter.. 
https://jdbc.postgresql.org/documentation/use/

Also confusing to me is the existing parameter "sslResponseTimeout", 
this defaults to 5 seconds, and is already documented as 'the maximum 
time to wait for a response after requesting an SSL encrypted connection 
from the server'. Shouldn't this value be used in above case.

Lastly, seeing "socketTimeout", however I would not want to set this 
one, as it could interfere with long-running queries, and to me, should 
not be used during connection setup.

- Martin

--------------oSX3UTdJ6ZCL8c0LF62gHAQP
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 28/11/2023 21:28, Dave Cramer wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CADK3HHJDQjz1a8EbE7LE1Cv0S57zR7nZ02=9hLqKmqF7VOq2ww@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div dir="ltr">On Tue, 28 Nov 2023 at 09:07, Dave Cramer
          <a class="moz-txt-link-rfc2396E" href="mailto:davecramer@postgres.rocks">&lt;davecramer@postgres.rocks&gt;</a> wrote:
          <div class="gmail_quote">
            <blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
              <div dir="ltr">Hi Martin,
                <div><br>
                </div>
                <div>Thanks for the report. I'll have a look. <br
                    clear="all">
                  <div>
                    <div dir="ltr" class="gmail_signature">
                      <div dir="ltr">Dave Cramer</div>
                    </div>
                  </div>
                </div>
              </div>
              <br>
              <div class="gmail_quote">
                <div dir="ltr" class="gmail_attr">On Tue, 28 Nov 2023 at
                  08:27, Martin Lichtin &lt;<a
                    href="mailto:lichtin@yahoo.com" target="_blank"
                    moz-do-not-send="true" class="moz-txt-link-freetext">lichtin@yahoo.com</a>&gt;
                  wrote:<br>
                </div>
                <blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
                  <div>
                    <p><font face="Calibri">Hi</font></p>
                    <p><font face="Calibri">I'm seeing this thread
                        hanging in the "getConnection" method, with no
                        timeout in sight.<br>
                      </font><font face="Calibri">However, the </font><font
                        face="Calibri">PGXADataSource </font><font
                        face="Calibri">is configured with a</font>
                      "connectTimeout" of 10 seconds. </p>
                    <p><font face="Calibri">   java.lang.Thread.State:
                        RUNNABLE<br>
                            at
                        java.net.SocketInputStream.socketRead0(Native
                        Method)<br>
                            at
                        java.net.SocketInputStream.socketRead(SocketInputStream.java:116)<br>
                            at
                        java.net.SocketInputStream.read(SocketInputStream.java:171)<br>
                            at
                        java.net.SocketInputStream.read(SocketInputStream.java:141)<br>
                            at
sun.security.ssl.SSLSocketInputRecord.read(SSLSocketInputRecord.java:464)<br>
                            at
sun.security.ssl.SSLSocketInputRecord.decode(SSLSocketInputRecord.java:165)<br>
                            at
                        sun.security.ssl.SSLTransport.decode(SSLTransport.java:109)<br>
                            at
                        sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1392)<br>
                            at
sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1300)<br>
                            at
                        sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:435)<br>
                            at
                        org.postgresql.ssl.MakeSSL.convert(MakeSSL.java:41)<br>
                        ...<br>
                            at
                        java.sql.DriverManager.getConnection(DriverManager.java:247)<br>
                            at
org.postgresql.ds.common.BaseDataSource.getConnection(BaseDataSource.java:103)<br>
                            at
                        org.postgresql.xa.PGXADataSource.getXAConnection(PGXADataSource.java:49)<br>
                            at
                        org.postgresql.xa.PGXADataSource.getXAConnection(PGXADataSource.java:35)</font></p>
                    <p>Any reason this timeout is not being applied
                      here?</p>
                    <p>The version in use here is 42.3.6<br>
                    </p>
                  </div>
                </blockquote>
              </div>
            </blockquote>
            <div><br>
            </div>
            <div>This <a
                href="https://github.com/pgjdbc/pgjdbc/pull/3040"
                moz-do-not-send="true">Make sure to pass any network
                timeouts to the new SSL connection. by davecramer · Pull
                Request #3040 · pgjdbc/pgjdbc (github.com)</a> should
              fix the problem, can you check ?</div>
          </div>
        </div>
      </div>
    </blockquote>
    <p>Thanks! I'll try. Was hoping for a SNAPSHOT version with this
      change in, but looks like these are no longer produced(?),
      although mentioned here <a class="moz-txt-link-freetext" href="https://jdbc.postgresql.org/download/">https://jdbc.postgresql.org/download/</a> 
      Anyways, it will be quite hard to reproduce this socket-read hang
      situation, so not sure I'll be able to test the change :)<br>
    </p>
    <p>Some more observations (obv from a newcomer to this space..):<br>
    </p>
    <p>As mentioned I'm setting "connectTimeout". Is this value somehow
      trickling down, and ending up at what's called "networkTimeout" in
      the code?<br>
      I'm asking as networkTimeout is not a connection parameter..
      <a class="moz-txt-link-freetext" href="https://jdbc.postgresql.org/documentation/use/">https://jdbc.postgresql.org/documentation/use/</a></p>
    <p>Also confusing to me is the existing parameter
      "sslResponseTimeout", this defaults to 5 seconds, and is already
      documented as 'the maximum time to wait for a response after
      requesting an SSL encrypted connection from the server'. Shouldn't
      this value be used in above case.</p>
    <p>Lastly, seeing "socketTimeout", however I would not want to set
      this one, as it could interfere with long-running queries, and to
      me, should not be used during connection setup.<br>
    </p>
    <p>- Martin<br>
    </p>
  </body>
</html>

--------------oSX3UTdJ6ZCL8c0LF62gHAQP--