From: Tom Lane <tgl@sss.pgh.pa.us>
To: mahendrakar s <mahendrakarforpg@gmail.com>
cc: pgsql-novice <pgsql-novice@lists.postgresql.org>
Subject: Re: best way to apply and work on the patches of the pg community
In-reply-to: 
 <CABkiuWpOj1XZokr3yhSD0DepyLXYa0JsZF3wyTtTmcPGGSapYQ@mail.gmail.com>
References: 
 <CABkiuWpOj1XZokr3yhSD0DepyLXYa0JsZF3wyTtTmcPGGSapYQ@mail.gmail.com>
Comments: In-reply-to mahendrakar s <mahendrakarforpg@gmail.com>
	message dated "Fri, 15 Jul 2022 21:03:04 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3401795.1657902814.1@sss.pgh.pa.us>
Date: Fri, 15 Jul 2022 12:33:34 -0400
Message-ID: <3401796.1657902814@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3401796.1657902814%40sss.pgh.pa.us>
Precedence: bulk

mahendrakar s <mahendrakarforpg@gmail.com> writes:
> I would like to work on a patch published on hackers community( patch is
> from June, 2021). I cloned postgres code and tried to  apply the patch and
> got errors.

> *patch -p1 < ../0001-auth-generalize-SASL-mechanisms.patch*
> patching file src/backend/libpq/auth-scram.c
> Hunk #1 FAILED at 101.
> Hunk #2 FAILED at 170.
> Hunk #3 FAILED at 199.
> Hunk #4 FAILED at 215.
> Hunk #5 FAILED at 325.

> Can you please let me know what is the recommended way to apply the patches
> for me to begin the work?

"patch -p1" is the way that usually works the best for me.  My guess
here is that the patch in question is out of date and will need manual
adjustment to apply to HEAD.  There have been some pretty significant
changes in that code in the last year, eg 9fd85570d.

Sometimes --ignore-whitespace helps, but I doubt that's the main
problem in this case.

			regards, tom lane