MIME-Version: 1.0
References: 
 <CABkiuWpOj1XZokr3yhSD0DepyLXYa0JsZF3wyTtTmcPGGSapYQ@mail.gmail.com>
In-Reply-To: 
 <CABkiuWpOj1XZokr3yhSD0DepyLXYa0JsZF3wyTtTmcPGGSapYQ@mail.gmail.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Fri, 15 Jul 2022 09:11:40 -0700
Message-ID: 
 <CAKFQuwayR4V2YCtCx=aqoca_gV2ysoAoa0Vj87StPU7QQO8ktw@mail.gmail.com>
Subject: Re: best way to apply and work on the patches of the pg community
To: mahendrakar s <mahendrakarforpg@gmail.com>
Cc: pgsql-novice <pgsql-novice@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000062a3305e3da4777"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKFQuwayR4V2YCtCx%3Daqoca_gV2ysoAoa0Vj87StPU7QQO8ktw%40mail.gmail.com>
Precedence: bulk

--000000000000062a3305e3da4777
Content-Type: text/plain; charset="UTF-8"

On Fri, Jul 15, 2022 at 8:33 AM mahendrakar s <mahendrakarforpg@gmail.com>
wrote:

> Hi Pg team,
>
> I would like to work on a patch published on hackers community( patch is
> from June, 2021). I cloned postgres code and tried to  apply the patch and
> got errors.
>
> *patch -p1 < ../0001-auth-generalize-SASL-mechanisms.patch*
> patching file src/backend/libpq/auth-scram.c
> Hunk #1 FAILED at 101.
> Hunk #2 FAILED at 170.
> Hunk #3 FAILED at 199.
> Hunk #4 FAILED at 215.
> Hunk #5 FAILED at 325.
>
> Can you please let me know what is the recommended way to apply the
> patches for me to begin the work?
>
>
I'm still in a bit of trial-and-error mode myself but I try to use `git
apply` first, possibly after making sure that the files are newline only
line endings.

David J.

--000000000000062a3305e3da4777
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:arial,helvetica,sans-serif"><span style=3D"font-family:Arial,Helve=
tica,sans-serif">On Fri, Jul 15, 2022 at 8:33 AM mahendrakar s &lt;<a href=
=3D"mailto:mahendrakarforpg@gmail.com">mahendrakarforpg@gmail.com</a>&gt; w=
rote:</span><br></div></div><div class=3D"gmail_quote"><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">Hi Pg team,=
<div><br></div><div>I would like to work on a patch published on hackers co=
mmunity( patch is from June, 2021). I cloned postgres code and tried to=C2=
=A0 apply the patch and got errors.</div><div><b><br></b></div><div><b>patc=
h -p1 &lt; ../0001-auth-generalize-SASL-mechanisms.patch</b><br></div><div>=
<div>patching file src/backend/libpq/auth-scram.c</div><div>Hunk #1 FAILED =
at 101.</div><div>Hunk #2 FAILED at 170.</div><div>Hunk #3 FAILED at 199.</=
div><div>Hunk #4 FAILED at 215.</div><div>Hunk #5 FAILED at 325.</div></div=
><div><br></div><div>Can you please let me know what is the recommended way=
 to apply the patches for me to begin the work?</div><div><br></div></div><=
/div></blockquote><div><br></div><div class=3D"gmail_default" style=3D"font=
-family:arial,helvetica,sans-serif">I&#39;m still in a bit of trial-and-err=
or mode myself but I try to use `git apply` first, possibly after making su=
re that the files are newline only line endings.</div><div class=3D"gmail_d=
efault" style=3D"font-family:arial,helvetica,sans-serif"><br></div><div cla=
ss=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif">David=
 J.</div><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,=
sans-serif"></div></div></div>

--000000000000062a3305e3da4777--