Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otoPv-000220-Od for pgsql-novice@arkaria.postgresql.org; Sat, 12 Nov 2022 11:11:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1otoPu-0006As-Kd for pgsql-novice@arkaria.postgresql.org; Sat, 12 Nov 2022 11:11:18 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otoPu-0006Aj-9e for pgsql-novice@lists.postgresql.org; Sat, 12 Nov 2022 11:11:18 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1otoPr-00079Z-9U for pgsql-novice@lists.postgresql.org; Sat, 12 Nov 2022 11:11:17 +0000 Received: by mail-pj1-x1031.google.com with SMTP id o7so6507583pjj.1 for ; Sat, 12 Nov 2022 03:11:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=jhSM6efLGxOz980cTJ2HIZPiloVc58qjeBt7uaReSh8=; b=XZM/2pg4T4xZoYo1R5W0GwSoxardvxOH5j48xGr+GIzM3yy3gpU2+hILZxlx7PCcIu lRCGZE7u1ePcmY0q8gEcoSPULxGSsLiCpqstgHe7W1D9m1RIDWYyngCOfvwg2Rq36+Xj gNPMFMeePuQhMi4rm99HaBYtq7IiLnUw818okF1BdajTU07rdm/61e2K3KDAXYuVGiCT zKKn/hsqizeJR/WblpWmW+1MMoGBpEkHn2TP9ARjjWgIaR9HWX1up5xk5vEKNwxNYt9J gRmwLQNhkMngAWFrHdS8JWtswrSz6ZFYKvKdooRHXbY2k00jCZbA6zjuAujv/PxuikNP 6IMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jhSM6efLGxOz980cTJ2HIZPiloVc58qjeBt7uaReSh8=; b=DklTekz8RlIqghvC4yOKEJRDUoe4k+wPlO3RxtlHvmyfVs3jxKNkFdnj2c8p1CUXNE VvuJPxK8fUwgFr3pUrm0w7fCKOPjBS/ccWzMlcoTmEWnZUZLg91Xfb1cYR4Ds6H5lMJQ pCfD3ZM3RcsXQh8Sv+yXZxjURqIBFfSGs9oG1YVuSTMgX+GDyKIORqbE2jIs/JE5y6NL 6npvMWUAZxk5pDMfPfiqYLEDqd5snglZI4+j5truUM4cA3R17Pn8gCe/WB3FRtbcI2r1 xL0lfKnd6dSUJB4jGLTr5K6KPEa3uV2sRONBHcHs5ON0zdk5q0erUF/lSZuPTIFOuG9L IOXw== X-Gm-Message-State: ANoB5pmKE+UrKitI9Oi3H9j6Lg3s7LZbLR4LHxxLG+ULQ0up7Z0zLkaY I54o9yd0ekwCcgui9LoO+nSkt1uXoxs= X-Google-Smtp-Source: AA0mqf4nHcDiYt1BIyemro8LbLocl7ldqhfniXPg1cIa22kjmorDqeDZ5OunZ85nusvuOBvvSJwV8g== X-Received: by 2002:a17:90a:2e17:b0:212:ed83:1224 with SMTP id q23-20020a17090a2e1700b00212ed831224mr6262044pjd.6.1668251473914; Sat, 12 Nov 2022 03:11:13 -0800 (PST) Received: from [10.0.2.15] ([27.57.114.71]) by smtp.gmail.com with ESMTPSA id s34-20020a635262000000b0042988a04bfdsm2670616pgl.9.2022.11.12.03.11.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Nov 2022 03:11:13 -0800 (PST) Content-Type: multipart/alternative; boundary="------------YhuArASzQDzq69t8UYS5pt6F" Message-ID: Date: Sat, 12 Nov 2022 16:41:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-US To: pgsql-novice@lists.postgresql.org From: Ankit Kumar Pandey Subject: Distinct tightly coupled with Agg List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------YhuArASzQDzq69t8UYS5pt6F Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello, I am looking at todo item /Implement DISTINCT clause in window aggregates /and while looking at code, I found /distinct/ tightly coupled with Agg function. Looking at another todo item/Do we really need so much duplicated code between Agg and WindowAgg?/  I was wondering what is general stance on this? If Agg/WindowAgg gets harmonized, implementing distinct would be lot more intuitive. Should this be attempted first? If this is not necessary, I assume making distinct a standalone piece should be an option too? Thanks, Ankit --------------YhuArASzQDzq69t8UYS5pt6F Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hello,

I am looking at todo item Implement DISTINCT clause in window aggregates and while looking at code, I found distinct tightly coupled with Agg function. Looking at another todo item Do we really need so much duplicated code between Agg and WindowAgg?  I was wondering what is general stance on this?

If Agg/WindowAgg gets harmonized, implementing distinct would be lot more intuitive. Should this be attempted first? If this is not necessary, I assume making distinct a standalone piece should be an option too?

Thanks,

Ankit

--------------YhuArASzQDzq69t8UYS5pt6F--