Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qdDmS-002cjh-4u for pgsql-odbc@arkaria.postgresql.org; Mon, 04 Sep 2023 17:54:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qdDmQ-00DM9y-1P for pgsql-odbc@arkaria.postgresql.org; Mon, 04 Sep 2023 17:54:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qdDmP-00DM91-Ps for pgsql-odbc@lists.postgresql.org; Mon, 04 Sep 2023 17:54:29 +0000 Received: from pgintl.fastcrypt.com ([149.56.129.164]) by makus.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qdDmH-002itK-ME for pgsql-odbc@postgresql.org; Mon, 04 Sep 2023 17:54:23 +0000 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by pgintl.fastcrypt.com (Postfix) with ESMTPSA id 8DACF20319 for ; Mon, 4 Sep 2023 13:54:18 -0400 (EDT) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-500c37d479aso2621481e87.2 for ; Mon, 04 Sep 2023 10:54:18 -0700 (PDT) X-Gm-Message-State: AOJu0YxixYcnkIo5kT558y+6WKufnSVu1CDuF5qFinYP8++Pmj7kES6G gXqqchOj+VYgwiZA6Bf07uRcWhOgb+4G8Vt4Gos= X-Google-Smtp-Source: AGHT+IFWRwCLtvOQSMzg0TwszLmJcT8iguxZwDa/1Ccr+yOlbv+8AAKpo1eAj/afoTVa0vhdJo0MtvOeTIv9itb2ymE= X-Received: by 2002:ac2:47f9:0:b0:500:9619:d9c9 with SMTP id b25-20020ac247f9000000b005009619d9c9mr6763750lfp.61.1693850056791; Mon, 04 Sep 2023 10:54:16 -0700 (PDT) MIME-Version: 1.0 References: <5D27E7EF-BBA7-4A44-8FA5-17BAEFED6EB4@enterprisedb.com> In-Reply-To: From: Dave Cramer Date: Mon, 4 Sep 2023 13:53:59 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Psqlodbc build fails on linux To: Moazzum Ali Cc: Michael Paquier , pgsql-odbc@postgresql.org Content-Type: multipart/alternative; boundary="000000000000f01d5b06048c32ab" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000f01d5b06048c32ab Content-Type: text/plain; charset="UTF-8" Seems like the better solution is to use Michael's suggestion as that is what PG does. Dave Cramer www.postgres.rocks On Mon, 4 Sept 2023 at 12:28, Moazzum Ali wrote: > Dave, > > Is it something that can be fixed on PG or psqlodbc side or you would also > suggest what Michael suggested? I have tried that environment rule though > and it works. > > Thanks, > Moazzum > > On Mon, Sep 4, 2023, 9:07 PM Dave Cramer > wrote: > >> >> >> On Mon, 4 Sept 2023 at 10:23, Dave Cramer >> wrote: >> >>> >>> >>> On Sun, 3 Sept 2023 at 19:46, Michael Paquier >>> wrote: >>> >>>> On Thu, Aug 31, 2023 at 06:28:06AM +0500, Moazzum Ali wrote: >>>> > One way to fix the error is to include the following line before >>>> > #include "pqexpbuffer.h" in connection.h and statement.h >>>> > #include >>>> >>>> Wouldn't it be better to enforce an environment rule in psqlodbc.h >>>> instead? PostgreSQL enforces PG_USE_STDBOOL already on Windows, and >>>> I am pretty sure that it would be OK to do the same in other *nix >>>> places where anybody cares about ODBC. >>>> >>> >>> I'm guessing this is a debian thing as I just built this successfully on >>> a redhat (ish) system >>> >> >> It pays to read all of the above before trying to replicate. I was >> building against 15, not 16 >> I see the failure now >> >>> >>> Dave >>> >> --000000000000f01d5b06048c32ab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Seems like the better solution is to use Michael's sug= gestion as that is what=C2=A0PG does.

Dave Cramer
www.postgres.rocks

<= /div>

On Mon, 4 Sept 2023 at 12:28, Moazzum Ali <moazzum.ali@enterprisedb.com> wrote:
Dave,=

Is it something that can be fixed o= n PG or psqlodbc side or you would also suggest what Michael suggested? I h= ave tried that environment rule though and it works.

Thanks,
Moazzum

On Mon, Sep 4, 2023, 9:07 PM Dave Cramer <davecramer@postgres.rocks&= gt; wrote:


On Mon, 4 Sept 2023 at 10:23, Dave Cramer = <davecramer@postgres.rocks> wrote:


On Sun, 3 Se= pt 2023 at 19:46, Michael Paquier <michael@paquier.xyz> wrote:
On Thu, Aug 31, 2= 023 at 06:28:06AM +0500, Moazzum Ali wrote:
> One way to fix the error is to include the following line before
> #include "pqexpbuffer.h" in connection.h and statement.h
> #include <stdbool.h>

Wouldn't it be better to enforce an environment rule in psqlodbc.h
instead?=C2=A0 PostgreSQL enforces PG_USE_STDBOOL already on Windows, and I am pretty sure that it would be OK to do the same in other *nix
places where anybody cares about ODBC.

= I'm guessing this is a debian thing as I just built this successfully o= n a redhat (ish) system=C2=A0

=
It pays to read all of the above before trying to replicate. I was bui= lding against 15, not 16
I see the failure now=C2=A0

Dave
--000000000000f01d5b06048c32ab--