MIME-Version: 1.0
References: <5D27E7EF-BBA7-4A44-8FA5-17BAEFED6EB4@enterprisedb.com>
 <ZPUatGNtOSe/kfDX@paquier.xyz>
 <CADK3HHLovT+PAnGc3SgoFSY7R+qQsJ6iTX=MOML+otnZzMZ5Yw@mail.gmail.com>
In-Reply-To: 
 <CADK3HHLovT+PAnGc3SgoFSY7R+qQsJ6iTX=MOML+otnZzMZ5Yw@mail.gmail.com>
From: Dave Cramer <davecramer@postgres.rocks>
Date: Mon, 4 Sep 2023 12:07:09 -0400
Message-ID: 
 <CADK3HHL5kLg77AAes0G16K9Ueuhao+5wd=4=Bjv2sfOaoOWYjg@mail.gmail.com>
Subject: Re: Psqlodbc build fails on linux
To: Michael Paquier <michael@paquier.xyz>
Cc: Moazzum Ali <moazzum.ali@enterprisedb.com>, pgsql-odbc@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000e4023a06048ab4a1"
Archived-At: 
 <https://www.postgresql.org/message-id/CADK3HHL5kLg77AAes0G16K9Ueuhao%2B5wd%3D4%3DBjv2sfOaoOWYjg%40mail.gmail.com>
Precedence: bulk

--000000000000e4023a06048ab4a1
Content-Type: text/plain; charset="UTF-8"

On Mon, 4 Sept 2023 at 10:23, Dave Cramer <davecramer@postgres.rocks> wrote:

>
>
> On Sun, 3 Sept 2023 at 19:46, Michael Paquier <michael@paquier.xyz> wrote:
>
>> On Thu, Aug 31, 2023 at 06:28:06AM +0500, Moazzum Ali wrote:
>> > One way to fix the error is to include the following line before
>> > #include "pqexpbuffer.h" in connection.h and statement.h
>> > #include <stdbool.h>
>>
>> Wouldn't it be better to enforce an environment rule in psqlodbc.h
>> instead?  PostgreSQL enforces PG_USE_STDBOOL already on Windows, and
>> I am pretty sure that it would be OK to do the same in other *nix
>> places where anybody cares about ODBC.
>>
>
> I'm guessing this is a debian thing as I just built this successfully on a
> redhat (ish) system
>

It pays to read all of the above before trying to replicate. I was building
against 15, not 16
I see the failure now

>
> Dave
>

--000000000000e4023a06048ab4a1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, 4 Sept 2023 at 10:23, Dave Cr=
amer &lt;davecramer@postgres.rocks&gt; wrote:<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br></div><=
br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun,=
 3 Sept 2023 at 19:46, Michael Paquier &lt;<a href=3D"mailto:michael@paquie=
r.xyz" target=3D"_blank">michael@paquier.xyz</a>&gt; wrote:<br></div><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex">On Thu, Aug 31, 2023 at 06:28:0=
6AM +0500, Moazzum Ali wrote:<br>
&gt; One way to fix the error is to include the following line before<br>
&gt; #include &quot;pqexpbuffer.h&quot; in connection.h and statement.h<br>
&gt; #include &lt;stdbool.h&gt;<br>
<br>
Wouldn&#39;t it be better to enforce an environment rule in psqlodbc.h<br>
instead?=C2=A0 PostgreSQL enforces PG_USE_STDBOOL already on Windows, and<b=
r>
I am pretty sure that it would be OK to do the same in other *nix<br>
places where anybody cares about ODBC.<br></blockquote><div><br></div><div>=
I&#39;m guessing this is a debian thing as I just built this successfully o=
n a redhat (ish) system=C2=A0</div></div></div></blockquote><div><br></div>=
<div>It pays to read all of the above before trying to replicate. I was bui=
lding against 15, not 16</div><div>I see the failure now=C2=A0</div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"g=
mail_quote"><div><br></div><div>Dave</div></div></div>
</blockquote></div></div>

--000000000000e4023a06048ab4a1--