MIME-Version: 1.0
References: 
 <CADF4wWpfy44sx0yTpcWmkvW_j-3-KCZDwaJnSK3H2+C+90DMCw@mail.gmail.com>
In-Reply-To: 
 <CADF4wWpfy44sx0yTpcWmkvW_j-3-KCZDwaJnSK3H2+C+90DMCw@mail.gmail.com>
From: Dave Cramer <davecramer@postgres.rocks>
Date: Mon, 25 Mar 2024 06:59:25 -0400
Message-ID: 
 <CADK3HHLB15KyoC47Z25kXiyYEPD5CwYTNRjmN9xkrfiD1D6Ojw@mail.gmail.com>
Subject: Re: [PATCH] Using mimalloc to improve performance and reduce memory
 allocation lock contention
To: Adrian Grucza <adrian.grucza@iress.com>
Cc: pgsql-odbc@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000027a50f06147a12e7"
Archived-At: 
 <https://www.postgresql.org/message-id/CADK3HHLB15KyoC47Z25kXiyYEPD5CwYTNRjmN9xkrfiD1D6Ojw%40mail.gmail.com>
Precedence: bulk

--00000000000027a50f06147a12e7
Content-Type: text/plain; charset="UTF-8"

On Mon, 25 Mar 2024 at 01:42, Adrian Grucza <adrian.grucza@iress.com> wrote:

> Hi,
>
> We have a multi-threaded Windows application that was experiencing delays
> due to high lock contention in memory allocations from the PostgreSQL ODBC
> driver. We tried modifying the driver to use mimalloc
> <https://github.com/microsoft/mimalloc>, which is a memory allocator with
> better performance characteristics. After deploying this change, the delays
> due to lock contention disappeared. It has been running on thousands of our
> production deployments for 9 months without issue.
>
> I've created this pull request
> <https://github.com/postgresql-interfaces/psqlodbc/pull/6> so that others
> can benefit from this change by building the driver with the _MIMALLOC_
> symbol defined and linking to the mimalloc library.
>
> In my patch, the usage of mimalloc is off by default, so it should be safe
> to merge. But I'd like to get people's thoughts on whether it should be
> enabled by default so that people can benefit from this change without
> having to build the driver themselves.
>

Cool,

Thanks, I will have a look

Dave

>

--00000000000027a50f06147a12e7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div><div><div dir=3D"ltr" class=3D"gmail=
_signature"><div dir=3D"ltr"><br></div></div></div></div></div><br><div cla=
ss=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, 25 Mar 202=
4 at 01:42, Adrian Grucza &lt;<a href=3D"mailto:adrian.grucza@iress.com">ad=
rian.grucza@iress.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex"><div><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr=
">Hi,<div><br></div><div><div>We have a multi-threaded Windows application =
that was experiencing delays due to high lock contention in memory allocati=
ons from the PostgreSQL ODBC driver. We tried modifying the driver to use <=
a href=3D"https://github.com/microsoft/mimalloc" target=3D"_blank">mimalloc=
</a>, which is a memory allocator with better performance characteristics. =
After deploying this change, the delays due to lock contention disappeared.=
 It has been running on thousands of our production deployments for 9 month=
s without issue.</div><div><br></div><div>I&#39;ve created <a href=3D"https=
://github.com/postgresql-interfaces/psqlodbc/pull/6" target=3D"_blank">this=
 pull request</a> so that others can benefit from this change by building t=
he driver with the <font face=3D"monospace">_MIMALLOC_</font> symbol define=
d and linking to the mimalloc library.</div></div><div><br></div><div>In my=
 patch, the usage of mimalloc is off by default, so it=C2=A0should be safe =
to merge. But I&#39;d like to get people&#39;s thoughts on whether it shoul=
d be enabled by default so that people can benefit from this change without=
 having to build the driver themselves.<br></div></div></div></div></div></=
blockquote><div><br></div><div>Cool,=C2=A0</div><div><br></div><div>Thanks,=
 I will have a look</div><div><br></div><div>Dave<br></div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex"><div></div></blockquote></div></div>

--00000000000027a50f06147a12e7--