Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-odbc-owner+archive@lists.postgresql.org>)
	id 1qdAUe-002PxE-Ur
	for pgsql-odbc@arkaria.postgresql.org; Mon, 04 Sep 2023 14:23:56 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-odbc-owner+archive@lists.postgresql.org>)
	id 1qdAUd-00Bl6T-QI
	for pgsql-odbc@arkaria.postgresql.org; Mon, 04 Sep 2023 14:23:55 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <davecramer@postgres.rocks>)
	id 1qdAUd-00Bl6E-I1
	for pgsql-odbc@lists.postgresql.org; Mon, 04 Sep 2023 14:23:55 +0000
Received: from pgintl.fastcrypt.com ([149.56.129.164])
	by magus.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <davecramer@postgres.rocks>)
	id 1qdAUZ-0030CZ-Nt
	for pgsql-odbc@postgresql.org; Mon, 04 Sep 2023 14:23:54 +0000
Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com
 [209.85.208.41])
	by pgintl.fastcrypt.com (Postfix) with ESMTPSA id 4C3952031B
	for <pgsql-odbc@postgresql.org>; Mon,  4 Sep 2023 10:23:49 -0400 (EDT)
Received: by mail-ed1-f41.google.com with SMTP id
 4fb4d7f45d1cf-52a23227567so2020409a12.0
        for <pgsql-odbc@postgresql.org>; Mon, 04 Sep 2023 07:23:49 -0700 (PDT)
X-Gm-Message-State: AOJu0YyI9tr9E/B7BCLJfNwGS5YIhyUaGNZXIlghehMRlLCdax/BDtPc
	RCEeHoOQ0KYzKaBiX/Iy6ERtPZYw/CBtGSpo6VQ=
X-Google-Smtp-Source: 
 AGHT+IGcUPRd1pPovHeh6jIAxVhLo4TQtP3LZG9ueyfQO2/NMbXUhFwhgUFBkodeiA/5qu1I4Pnzmyqdl7L8SwrFpxg=
X-Received: by 2002:aa7:d34f:0:b0:51d:9399:4707 with SMTP id
 m15-20020aa7d34f000000b0051d93994707mr6052437edr.26.1693837428315; Mon, 04
 Sep 2023 07:23:48 -0700 (PDT)
MIME-Version: 1.0
References: <5D27E7EF-BBA7-4A44-8FA5-17BAEFED6EB4@enterprisedb.com>
 <ZPUatGNtOSe/kfDX@paquier.xyz>
In-Reply-To: <ZPUatGNtOSe/kfDX@paquier.xyz>
From: Dave Cramer <davecramer@postgres.rocks>
Date: Mon, 4 Sep 2023 10:23:31 -0400
X-Gmail-Original-Message-ID: 
 <CADK3HHLovT+PAnGc3SgoFSY7R+qQsJ6iTX=MOML+otnZzMZ5Yw@mail.gmail.com>
Message-ID: 
 <CADK3HHLovT+PAnGc3SgoFSY7R+qQsJ6iTX=MOML+otnZzMZ5Yw@mail.gmail.com>
Subject: Re: Psqlodbc build fails on linux
To: Michael Paquier <michael@paquier.xyz>
Cc: Moazzum Ali <moazzum.ali@enterprisedb.com>, pgsql-odbc@postgresql.org
Content-Type: multipart/alternative; boundary="00000000000038dd40060489424c"
List-Id: <pgsql-odbc.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-odbc@lists.postgresql.org>
List-Owner: <mailto:pgsql-odbc-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-odbc>
Archived-At: 
 <https://www.postgresql.org/message-id/CADK3HHLovT%2BPAnGc3SgoFSY7R%2BqQsJ6iTX%3DMOML%2BotnZzMZ5Yw%40mail.gmail.com>
Precedence: bulk

--00000000000038dd40060489424c
Content-Type: text/plain; charset="UTF-8"

On Sun, 3 Sept 2023 at 19:46, Michael Paquier <michael@paquier.xyz> wrote:

> On Thu, Aug 31, 2023 at 06:28:06AM +0500, Moazzum Ali wrote:
> > One way to fix the error is to include the following line before
> > #include "pqexpbuffer.h" in connection.h and statement.h
> > #include <stdbool.h>
>
> Wouldn't it be better to enforce an environment rule in psqlodbc.h
> instead?  PostgreSQL enforces PG_USE_STDBOOL already on Windows, and
> I am pretty sure that it would be OK to do the same in other *nix
> places where anybody cares about ODBC.
>

I'm guessing this is a debian thing as I just built this successfully on a
redhat (ish) system

Dave

--00000000000038dd40060489424c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Sun, 3 Sept 2023 at 19:46, Michael=
 Paquier &lt;<a href=3D"mailto:michael@paquier.xyz">michael@paquier.xyz</a>=
&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On T=
hu, Aug 31, 2023 at 06:28:06AM +0500, Moazzum Ali wrote:<br>
&gt; One way to fix the error is to include the following line before<br>
&gt; #include &quot;pqexpbuffer.h&quot; in connection.h and statement.h<br>
&gt; #include &lt;stdbool.h&gt;<br>
<br>
Wouldn&#39;t it be better to enforce an environment rule in psqlodbc.h<br>
instead?=C2=A0 PostgreSQL enforces PG_USE_STDBOOL already on Windows, and<b=
r>
I am pretty sure that it would be OK to do the same in other *nix<br>
places where anybody cares about ODBC.<br></blockquote><div><br></div><div>=
I&#39;m guessing this is a debian thing as I just built this successfully o=
n a redhat (ish) system=C2=A0</div><div><br></div><div>Dave</div></div></di=
v>

--00000000000038dd40060489424c--