public inbox for [email protected]
help / color / mirror / Atom feedFrom: Inoue,Hiroshi <[email protected]>
To: Marko Ristola <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: PostgreSQL ODBC mylog() uses lots of CPU in INTEGER field SQL query
Date: Wed, 12 May 2021 08:57:43 +0900
Message-ID: <CAFGcedUJbip1AY=kOKTueZuaiwjyiA-NBtk-c+u2HXUg-0vK_A@mail.gmail.com> (raw)
In-Reply-To: <CALndGf+qOJc6ZPfEAJgs_+CkE01QtEMQVEumGURHzzA+MYOuwg@mail.gmail.com>
References: <CALndGf+qOJc6ZPfEAJgs_+CkE01QtEMQVEumGURHzzA+MYOuwg@mail.gmail.com>
Hi Marko,
I would take care of your patch.
Thanks.
Hiroshi Inoue
2021年5月8日(土) 4:31 Marko Ristola <[email protected]>:
> I did a query of 4 million rows into an INTEGER field.
>
> Linux perf shows following profile (hottest functions):
>
> 9.91% bc_sqlselect psqlodbcw.so [.] mylog
> 9.64% bc_sqlselect psqlodbcw.so [.]
> QR_read_a_tuple_from_db
> 4.83% bc_sqlselect psqlodbcw.so [.]
> copy_and_convert_field
> 4.57% bc_sqlselect libpthread-2.17.so [.]
> pthread_mutex_unlock
> 4.51% bc_sqlselect libpthread-2.17.so [.] pthread_mutex_lock
> 4.40% bc_sqlselect psqlodbcw.so [.]
> SOCK_get_next_n_bytes.part.2
> 3.93% bc_sqlselect psqlodbcw.so [.] PGAPI_ExtendedFetch
>
> Following patch removes the only mylog() call (not a macro)
>
> from the PostgreSQL ODBC driver from consuming CPU:
>
> (MYLOG() macro is used to avoid the heavy mylog() call.)
>
>
> diff --git a/results.c b/results.c
> index 1f6a12c..ec89600 100644
> --- a/results.c
> +++ b/results.c
> @@ -4632,7 +4632,6 @@ SC_pos_add(StatementClass *stmt,
> goto cleanup;
> }
> MYLOG(0, "addstr=%s\n", addstr.data);
> - mylog("addstr=%s\n", addstr.data);
> s.qstmt->exec_start_row = s.qstmt->exec_end_row = s.irow;
> s.updyes = TRUE;
> ret = PGAPI_ExecDirect(hstmt, (SQLCHAR *) addstr.data,
> SQL_NTS, 0);
>
>
> Best Regards, Marko Ristola
>
> --
> Marko Ristola
> Software developer
> BC Platforms
>
> m. +358 40 593 2182
> e. [email protected]
> w. www.bcplatforms.com
>
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PostgreSQL ODBC mylog() uses lots of CPU in INTEGER field SQL query
In-Reply-To: <CAFGcedUJbip1AY=kOKTueZuaiwjyiA-NBtk-c+u2HXUg-0vK_A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox