Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qdQQD-003L6S-NG for pgsql-odbc@arkaria.postgresql.org; Tue, 05 Sep 2023 07:24:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qdQQB-0000Ue-Si for pgsql-odbc@arkaria.postgresql.org; Tue, 05 Sep 2023 07:24:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qdDoi-00DMhM-HX for pgsql-odbc@lists.postgresql.org; Mon, 04 Sep 2023 17:56:52 +0000 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qdDoe-002iuB-9u for pgsql-odbc@postgresql.org; Mon, 04 Sep 2023 17:56:50 +0000 Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-d71dd633f33so1430099276.2 for ; Mon, 04 Sep 2023 10:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1693850207; x=1694455007; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LcvlS3NetEKSHhjWYmNtkP7T3BRvc7Z3Rq0DHt6azI8=; b=Oc9BcM2+xTnvo2x5g9VeBj4TfarDFFBaekOF4E9Qwlddto4Rl+PELDQ6lwwVvxibBd D76OrAaeG9nDLlplqaS9LdFFIY0zYbFSgFwp8YF+pP3/8mbb+6BST+vX/1ZH5Uneyf96 nArJP/Zf6bc1NkHo2ys2ujjzroUneszD1vw/ucB/sqBI8wEuII3FD9mcD3BeybmKj7Ww sR0NdoYACn/GEnmgz1vW4Ii91+O8JXy0m3Ru4Hkn4hms5afJAJ8/Esliix4QHCWyGvQ8 Wg8nNtwGpj9PoBPQXV5OuwiEp4N3Y+3RHqYI1mEBpuJ+MkdrigLPCe7DRcGwrTy3o+Bi YKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693850207; x=1694455007; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LcvlS3NetEKSHhjWYmNtkP7T3BRvc7Z3Rq0DHt6azI8=; b=F65RZPlqV+oGCmuHFNCeELNou1dKEkw31nrrPO+XfFuACiN8GPvGxziBOwNZLsY4vS gaapexw+KXhh4PMftwUIQKZ7yllG9wNHQaLm0Yanfi+/bHlxUeeqoyoAxUsBdKglonkG ntN1HLGcIp0qeG/6KI5Yr+qeJwT8RDcmT4G9YzGBWXVpvFcW8VH9+4BYnca0eH2Njr/V u5v9d4pVz8K4jO0nTkVWVZ2VfVC6yxa+ZamPaUzQ+U4eyOBh31QHwBHdfshyTMATlEtr Q5pFwQgPCykNnyHNt+bmJSnNL/os800gV9TSdpLgVFRdvbzSispPh6hkiAuQ0i/XE7K4 ee0g== X-Gm-Message-State: AOJu0YxeQQu1OLuRcDyFVSodyrKsa5wXiYLUiFOFhp97/SpXnyOylYMr SSLwZUp5T+tVYwnnAce1l5Tr2jyZgJnWf7zhHj+PAw== X-Google-Smtp-Source: AGHT+IF+dqbkm425DXTyeX55C6QplphMC2aqQf0gLaBCN2W4m6GddC3RSwJA3FwmGebBcnTXAR+yYL8Ik//EMa49IEQ= X-Received: by 2002:a25:aa11:0:b0:d7a:c85b:278c with SMTP id s17-20020a25aa11000000b00d7ac85b278cmr11053359ybi.56.1693850207095; Mon, 04 Sep 2023 10:56:47 -0700 (PDT) MIME-Version: 1.0 References: <5D27E7EF-BBA7-4A44-8FA5-17BAEFED6EB4@enterprisedb.com> In-Reply-To: From: Moazzum Ali Date: Mon, 4 Sep 2023 22:55:50 +0500 Message-ID: Subject: Re: Psqlodbc build fails on linux To: Dave Cramer Cc: Michael Paquier , pgsql-odbc@postgresql.org Content-Type: multipart/alternative; boundary="000000000000e5b80306048c3b59" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000e5b80306048c3b59 Content-Type: text/plain; charset="UTF-8" Thanks Dave and Michael. On Mon, Sep 4, 2023, 10:54 PM Dave Cramer wrote: > Seems like the better solution is to use Michael's suggestion as that is > what PG does. > > Dave Cramer > www.postgres.rocks > > > On Mon, 4 Sept 2023 at 12:28, Moazzum Ali > wrote: > >> Dave, >> >> Is it something that can be fixed on PG or psqlodbc side or you would >> also suggest what Michael suggested? I have tried that environment rule >> though and it works. >> >> Thanks, >> Moazzum >> >> On Mon, Sep 4, 2023, 9:07 PM Dave Cramer >> wrote: >> >>> >>> >>> On Mon, 4 Sept 2023 at 10:23, Dave Cramer >>> wrote: >>> >>>> >>>> >>>> On Sun, 3 Sept 2023 at 19:46, Michael Paquier >>>> wrote: >>>> >>>>> On Thu, Aug 31, 2023 at 06:28:06AM +0500, Moazzum Ali wrote: >>>>> > One way to fix the error is to include the following line before >>>>> > #include "pqexpbuffer.h" in connection.h and statement.h >>>>> > #include >>>>> >>>>> Wouldn't it be better to enforce an environment rule in psqlodbc.h >>>>> instead? PostgreSQL enforces PG_USE_STDBOOL already on Windows, and >>>>> I am pretty sure that it would be OK to do the same in other *nix >>>>> places where anybody cares about ODBC. >>>>> >>>> >>>> I'm guessing this is a debian thing as I just built this successfully >>>> on a redhat (ish) system >>>> >>> >>> It pays to read all of the above before trying to replicate. I was >>> building against 15, not 16 >>> I see the failure now >>> >>>> >>>> Dave >>>> >>> --000000000000e5b80306048c3b59 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks=C2=A0Dave and Michael.

On Mon, Sep 4, 2023, 10:54 P= M Dave Cramer <davecramer@postgres.rocks> wrote:
Seems like the better solution is to u= se Michael's suggestion as that is what=C2=A0PG does.

Dave Cramer
www.postgres.rocks


On Mon, 4 Sept 2023 at 12:28, Moazzum Ali <moazzum.ali@enterprisedb.com> wrote:
Dave,
<= br>
Is it something that can be fixed on PG or psqlodbc si= de or you would also suggest what Michael suggested? I have tried that envi= ronment rule though and it works.

Thanks,
Moazzum

On Mon, Sep 4, = 2023, 9:07 PM Dave Cramer <davecramer@postgres.rocks> wrote:


On Mon, 4 Sept 2023 at 10:23, Dave Cramer <davecramer@po= stgres.rocks> wrote:


On Sun, 3 Sept 2023 at 19:46,= Michael Paquier <michael@paquier.xyz> wrote:
On Thu, Aug 31, 2023 at= 06:28:06AM +0500, Moazzum Ali wrote:
> One way to fix the error is to include the following line before
> #include "pqexpbuffer.h" in connection.h and statement.h
> #include <stdbool.h>

Wouldn't it be better to enforce an environment rule in psqlodbc.h
instead?=C2=A0 PostgreSQL enforces PG_USE_STDBOOL already on Windows, and I am pretty sure that it would be OK to do the same in other *nix
places where anybody cares about ODBC.

= I'm guessing this is a debian thing as I just built this successfully o= n a redhat (ish) system=C2=A0

=
It pays to read all of the above before trying to replicate. I was bui= lding against 15, not 16
I see the failure now=C2=A0

Dave
--000000000000e5b80306048c3b59--