MIME-Version: 1.0
From: V T <vova20007@gmail.com>
Date: Thu, 7 Oct 2021 02:22:31 +0300
Message-ID: 
 <CALAVXY5JMTkKvXWDEOyBwVb1t2M1-pqop7oNpkZC6bQgTskEcw@mail.gmail.com>
Subject: SQLGetDiagField bug
To: pgsql-odbc@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000046397005cdb76c7c"
Archived-At: 
 <https://www.postgresql.org/message-id/CALAVXY5JMTkKvXWDEOyBwVb1t2M1-pqop7oNpkZC6bQgTskEcw%40mail.gmail.com>
Precedence: bulk

--00000000000046397005cdb76c7c
Content-Type: text/plain; charset="UTF-8"

SQLGetDiagField(SQL_DIAG_NUMBER) with SQL_HANDLE_DBC returns SQL_NO_DATA
even if an error record exists.

if I request one of unimplemented info types
SQL_DATETIME_LITERALS
SQL_STANDARD_CLI_CONFORMANCE
SQL_XOPEN_CLI_YEAR

    SQLUINTEGER bitmask;
    SQLRETURN rc;

    rc = SQLGetInfo(hdbc, SQL_DATETIME_LITERALS, &bitmask, sizeof(bitmask),
NULL); // _ASSERT(rc == 0);
    if (rc != SQL_SUCCESS)
    {
        SQLLEN numRecs;
        SQLCHAR Msg[SQL_MAX_MESSAGE_LENGTH + 1];

        rc = SQLGetDiagField(SQL_HANDLE_DBC, hdbc, 0, SQL_DIAG_NUMBER,
&numRecs, 0, nullptr); // _ASSERT(rc == 0);
        // returns SQL_NO_DATA

        // but this returns valid message
        rc = SQLGetDiagRec(SQL_HANDLE_DBC, hdbc, 1, NULL, NULL, Msg,
sizeof(Msg), NULL); _ASSERT(rc == 0);
        __debugbreak();
    }


Also there is a typo in function PGAPI_GetTypeInfo(HSTMT hstmt, SQLSMALLINT
fSqlType) [info.c]
https://git.postgresql.org/gitweb/?p=psqlodbc.git;a=blob;f=info.c;h=2ce1a5acd19052c2525bdd5b2ab02701eb6cba1d;hb=HEAD#l1161
"RECISION" should be "PRECISION"

--00000000000046397005cdb76c7c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">SQLGetDiagField(SQL_DIAG_NUMBER) with SQL_HANDLE_DBC retur=
ns SQL_NO_DATA even if an error record exists.<br><br>if I request one of u=
nimplemented info types <br>SQL_DATETIME_LITERALS<br>SQL_STANDARD_CLI_CONFO=
RMANCE<br>SQL_XOPEN_CLI_YEAR<br><br>=C2=A0 =C2=A0 SQLUINTEGER bitmask;<br>=
=C2=A0 =C2=A0 SQLRETURN rc;<br><br>=C2=A0 =C2=A0 rc =3D SQLGetInfo(hdbc, SQ=
L_DATETIME_LITERALS, &amp;bitmask, sizeof(bitmask), NULL); // _ASSERT(rc =
=3D=3D 0);<br>=C2=A0 =C2=A0 if (rc !=3D SQL_SUCCESS)<br>=C2=A0 =C2=A0 {<br>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 SQLLEN numRecs;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
SQLCHAR Msg[SQL_MAX_MESSAGE_LENGTH + 1];<br><br>=C2=A0 =C2=A0 =C2=A0 =C2=A0=
 rc =3D SQLGetDiagField(SQL_HANDLE_DBC, hdbc, 0, SQL_DIAG_NUMBER, &amp;numR=
ecs, 0, nullptr); // _ASSERT(rc =3D=3D 0);<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 /=
/ returns SQL_NO_DATA<br><br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 // but this return=
s valid message<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 rc =3D SQLGetDiagRec(SQL_HAN=
DLE_DBC, hdbc, 1, NULL, NULL, Msg, sizeof(Msg), NULL); _ASSERT(rc =3D=3D 0)=
;<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 __debugbreak();<br>=C2=A0 =C2=A0 }<br><br>=
<br>Also there is a typo in function PGAPI_GetTypeInfo(HSTMT hstmt, SQLSMAL=
LINT fSqlType) [info.c]<br><a href=3D"https://git.postgresql.org/gitweb/?p=
=3Dpsqlodbc.git;a=3Dblob;f=3Dinfo.c;h=3D2ce1a5acd19052c2525bdd5b2ab02701eb6=
cba1d;hb=3DHEAD#l1161">https://git.postgresql.org/gitweb/?p=3Dpsqlodbc.git;=
a=3Dblob;f=3Dinfo.c;h=3D2ce1a5acd19052c2525bdd5b2ab02701eb6cba1d;hb=3DHEAD#=
l1161</a><br>&quot;RECISION&quot; should be &quot;PRECISION&quot;</div>

--00000000000046397005cdb76c7c--