Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 84C0264FC25 for ; Wed, 24 Sep 2008 11:55:20 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 31054-06 for ; Wed, 24 Sep 2008 11:55:17 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from smtp.guitar.ocn.ne.jp (guitar.ocn.ne.jp [122.28.30.209]) by postgresql.org (Postfix) with ESMTP id 136AD64FC1E for ; Wed, 24 Sep 2008 11:55:16 -0300 (ADT) Received: from IBMC9A0F63B40D (p5023-ipadfx01funabasi.chiba.ocn.ne.jp [218.43.105.23]) by smtp.guitar.ocn.ne.jp (Postfix) with SMTP id 7BBF629C8; Wed, 24 Sep 2008 23:55:12 +0900 (JST) Message-ID: <00a101c91e55$8ad86260$0b01a8c0@IBMC9A0F63B40D> From: "Hiroshi Saito" To: "Magnus Hagander" Cc: References: <03c301c91737$be5a2a30$0e01a8c0@IBMC9A0F63B40D> <48DA044D.10005@hagander.net> Subject: Re: Solve a problem of LC_TIME of windows. Date: Wed, 24 Sep 2008 23:55:10 +0900 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-2022-jp"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.3138 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.001 tagged_above=0 required=5 tests=STOX_REPLY_TYPE=0.001 X-Spam-Level: X-Archive-Number: 200809/163 X-Sequence-Number: 7178 Hi. ----- Original Message ----- From: "Magnus Hagander" > In principle, I think this patch looks good. > > Do you (or somebody else) have an example where this breaks in an > encoding where I can actually understand the characters, though ;-) That > would make testing a whole lot easier... > > Also, the patch needs error checking. strftime() can fail, and the > multibyte conversion functions can certainly fail. That will need to be > added. Ok, thanks! strftime return to 0. http://msdn.microsoft.com/en-us/library/fe06s4ak(VS.71).aspx MultiByteToWideChar and WideCharToMultiByte return to GetLastError. http://msdn.microsoft.com/en-us/library/ms776413(VS.85).aspx I will proposal the next patch.:-) BTW, this is SQL for a check. http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/DATECHECK.sql Probably, all are included. http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/LC_TIME_CHECK_LOCALE.sql Regards, Hiroshi Saito