Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id DC381650213 for ; Mon, 7 Jul 2008 11:51:28 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 56644-10 for ; Mon, 7 Jul 2008 11:51:16 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 2439D650595 for ; Mon, 7 Jul 2008 11:51:22 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m67Ep3ev010030; Mon, 7 Jul 2008 10:51:03 -0400 (EDT) To: Simon Riggs cc: ITAGAKI Takahiro , pgsql-hackers@postgresql.org Subject: Re: [PATCHES] WIP: executor_hook for pg_stat_statements In-reply-to: <1215414601.4051.432.camel@ebony.site> References: <20080623150535.946E.52131E4D@oss.ntt.co.jp> <1215161065.4051.26.camel@ebony.site> <20080707104202.73E5.52131E4D@oss.ntt.co.jp> <1215414601.4051.432.camel@ebony.site> Comments: In-reply-to Simon Riggs message dated "Mon, 07 Jul 2008 08:10:00 +0100" Date: Mon, 07 Jul 2008 10:51:03 -0400 Message-ID: <10029.1215442263@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200807/283 X-Sequence-Number: 120543 Simon Riggs writes: > On Mon, 2008-07-07 at 11:03 +0900, ITAGAKI Takahiro wrote: >> One issue is "tag" field. The type is now uint32. It's enough in my plugin, >> but if some people need to add more complex structures in PlannedStmt, >> Node type would be better rather than uint32. Which is better? > I was imagining that tag was just an index to another data structure, > but probably better if its a pointer. I don't want the tag there at all, much less converted to a pointer. What would the semantics be of copying the node, and why? Please justify why you must have this and can't do what you want some other way. regards, tom lane