Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 7174864FD0C for ; Fri, 18 Jul 2008 02:45:01 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 56659-03 for ; Fri, 18 Jul 2008 02:44:54 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 166B464FD09 for ; Fri, 18 Jul 2008 02:44:55 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id m6I5icFA010643; Fri, 18 Jul 2008 01:44:38 -0400 (EDT) To: Simon Riggs cc: Alvaro Herrera , List pgsql-patches Subject: Re: Is autovacuum doing a wraparound-avoiding VACUUM? In-reply-to: <1216335729.19656.683.camel@ebony.2ndQuadrant> References: <1216227339.19656.364.camel@ebony.2ndQuadrant> <20080717211044.GR3934@alvh.no-ip.org> <1216335729.19656.683.camel@ebony.2ndQuadrant> Comments: In-reply-to Simon Riggs message dated "Fri, 18 Jul 2008 00:02:09 +0100" Date: Fri, 18 Jul 2008 01:44:38 -0400 Message-ID: <10642.1216359878@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.025 tagged_above=0 required=5 tests=AWL=0.025 X-Spam-Level: X-Archive-Number: 200807/177 X-Sequence-Number: 6871 Simon Riggs writes: > On Thu, 2008-07-17 at 17:10 -0400, Alvaro Herrera wrote: >> I don't like your wording though; it feels too verbose (and you're >> losing the ANALYZE in case it's doing both things). How about >> >> snprintf(activity, MAX_AUTOVAC_ACTIV_LEN, >> "autovacuum: VACUUM%s%s", vac >> tab->at_doanalyze ? " ANALYZE" : "", >> tab->at_wraparound ? " (wraparound)" : ""); > Yes, looks good. May I suggest "(to prevent wraparound)" or something like that? Otherwise, +1. >> You're not proposing it for 8.3 right? > I think I am. It's an important diagnostic for your other fix. I agree, this is important for visibility into what's happening. The string isn't getting translated so I don't see any big downside to applying the patch in back branches. regards, tom lane