Subject: Re: [HACKERS] odd output in restore mode
From: Simon Riggs <simon@2ndquadrant.com>
To: Heikki Linnakangas <heikki@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Bruce Momjian <bruce@momjian.us>,
	Dave Page <dpage@pgadmin.org>,
	List pgsql-patches <pgsql-patches@postgresql.org>
In-Reply-To: <486A0A86.1080509@enterprisedb.com>
References: <200806302213.m5UMDCW22128@momjian.us>
	<48696C3F.4060901@dunslane.net> <1214901548.3845.544.camel@ebony.site>
	<486A0A86.1080509@enterprisedb.com>
Content-Type: text/plain
Date: Tue, 01 Jul 2008 12:49:47 +0100
Message-Id: <1214912987.3845.584.camel@ebony.site>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Tue, 2008-07-01 at 13:44 +0300, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> > Patch implements
> > 
> > * recommendation to use GnuWin32 cp on Windows
> > * provide "holdtime" delay, default 0 (on all platforms)
> > * default stays same on Windows="copy" to ensure people upgrading don't
> > get stung
> 
> This seems pretty kludgey to me. I wouldn't want to install GnuWin32 
> utilities on a production system just for the "cp" command, and I don't 
> know how I would tune holdtime properly for using "copy". And it seems 
> risky to have defaults that are known to not work reliably.
> 
> How about implementing a replacement function for "cp" ourselves? It 
> seems pretty trivial to do. We could use that on Unixes as well, which 
> would keep the differences between Win32 and other platforms smaller, 
> and thus ensure the codepath gets more testing.
> 
> (Sorry for jumping into the discussion so late, I didn't follow this 
> thread earlier, and just read it now in the archives while looking at 
> the patch.)

If you've heard complaints about any of this from users, I haven't.
AFAIK we're doing this because it *might* cause a problem. Bear in mind
that link is the preferred performance option, not copy. So AFAICS we're
tuning a secondary option on one specific port, without it being a
raised issue and in an area of code that will be superceded in the next
release.

So further embellishments would be a long way down my own priority list,
putting it politely. Yet I have no objections to the suggestion overall;
we have done that already for alter tablespace.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support